Three things that said one thing and did another

All three shipped in the last two commits, and all three are the same kind of
mistake: an interface that looks right and is not.

The folder settings page could not be scrolled. `.main` is a flex column with
`min-height: 0`, so a `.page` dropped straight into it overflows the viewport
with nothing to scroll -- Save and Back end up below the bottom of the window,
reachable by zooming out or by dragging the prompt textarea up out of the way.
Every other page of this shape already wraps its content in `.admin-scroll`;
this one did not. The two class names that scroll are one rule in admin.css
precisely so this is a wrapper somebody forgot rather than a value they got
wrong, and now it is noted.

The project directory was a text box, on the one screen that asks for an
absolute path on another machine. It is the same button-and-hidden-field the
new-chat screen uses, wired by `[data-dir-field]` in ui.js -- scoped to that
attribute so this and the composer's own handler cannot both answer one click
and open two dialogs. The composer keeps its own because it does more: it
follows the selected profile's default directory until somebody picks their
own, which only means something while a chat is being created. With no
connection chosen it says so rather than opening onto nothing, and Clear is
always there, because browsing somewhere and changing your mind before saving
needs a way back to "no opinion" as much as clearing a saved one does.

And "New chat" did not follow the Chat/Agent switch. The button sits above the
scroll area rather than inside the tree the switch swaps, so it went on saying
"New chat" over a list of agent chats. It moves to its own partial and arrives
out of band, the way the chat title already does. Renaming it to something
neutral would have hidden the bug rather than fixed it, and would have cost the
`?kind=agent` preselection the label is there to explain.

The tests that existed asserted a page load, which re-renders the button
anyway -- which is exactly why nobody saw it. The new ones assert the fragment.
The directory field was driven under a DOM stub first.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jaroslav Beneš
2026-08-04 10:40:01 +02:00
parent 5766446b84
commit 20040f53a8
9 changed files with 241 additions and 31 deletions
+44
View File
@@ -598,6 +598,50 @@ document.addEventListener("lembas:notify", function (event) {
setDir(profileDefault());
}
/* The same directory picker, on a form that is not the composer.
Scoped to `[data-dir-field]`, which the composer's own markup does not
carry -- otherwise this and `wire()` above would both answer one click and
open two dialogs. The composer keeps its own handler because it has more to
do: it follows the selected profile's default directory until somebody
chooses their own, which only makes sense while a chat is being created.
A path is something you would rather find than spell, and the text box this
replaced was the one control on the folder page that asked somebody to
remember an absolute path on another machine. */
document.addEventListener("click", function (event) {
var field = event.target.closest("[data-dir-field]");
if (!field) return;
var value = field.querySelector("[data-dir-value]");
var label = field.querySelector("[data-dir-label]");
if (!value) return;
function show(path) {
value.value = path || "";
if (label) label.textContent = path || "the connection's own default";
}
if (event.target.closest("[data-dir-clear]")) {
event.preventDefault();
show("");
return;
}
if (!event.target.closest("[data-dir-browse]")) return;
event.preventDefault();
/* The connection this folder points at. Browsing needs one, and saying so
beats a dialog that opens onto nothing. */
var form = field.closest("form");
var picker = form && form.querySelector('select[name="ssh_profile_id"]');
var profileId = picker ? picker.value : "";
if (!profileId) {
window.lembas.notify("Choose a connection first — there is nothing to browse without one.");
return;
}
window.lembas.chooseDirectory(profileId, value.value, show);
});
function scan() {
document.querySelectorAll("[data-agent-picker]").forEach(function (el) {
if (!el.dataset.wired) { el.dataset.wired = "1"; wire(el); }