The interface speaks Slovak
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -12,7 +12,7 @@
|
||||
<p class="text-sm faint">
|
||||
Filed
|
||||
<time datetime="{{ report.created_at.isoformat() }}">
|
||||
{{ report.created_at.strftime("%d %B %Y at %H:%M") }}
|
||||
{{ stamp(report.created_at, "%d %B %Y at %H:%M") }}
|
||||
</time>
|
||||
{%- if report.source == "schedule" %} by a schedule
|
||||
{%- elif report.source == "chat" %} from a chat
|
||||
@@ -23,7 +23,7 @@
|
||||
{% if report.error %}
|
||||
<div class="alert alert--warning" style="margin-top: var(--sp-4)">
|
||||
{{ icon("warning", "alert__icon") }}
|
||||
<span><strong>This run did not finish cleanly.</strong> {{ report.error }}</span>
|
||||
<span><strong>{{ t("This run did not finish cleanly.") }}</strong> {{ report.error }}</span>
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
@@ -47,7 +47,7 @@
|
||||
{% if report.owner_id == user.id %}
|
||||
<div class="btn-row" style="margin-top: var(--sp-6)">
|
||||
<form method="post" action="/api/reports/{{ report.id }}/delete"
|
||||
data-confirm="Delete this report? It cannot be brought back.">
|
||||
data-confirm="{{ t('Delete this report? It cannot be brought back.') }}">
|
||||
<button class="btn btn--sm btn--danger" type="submit">
|
||||
{{ icon("trash", "icon--sm") }} Delete
|
||||
</button>
|
||||
|
||||
@@ -6,11 +6,7 @@
|
||||
{% block heading %}Reports{% endblock %}
|
||||
|
||||
{% block reports_content %}
|
||||
<p class="admin-lede">
|
||||
Finished work, filed to be read later. A model writes one when you ask for it
|
||||
or when it finishes something worth keeping, and anything running on a
|
||||
schedule leaves its result here. Nothing on this page can be replied to.
|
||||
</p>
|
||||
<p class="admin-lede">{{ t("Finished work, filed to be read later. A model writes one when you ask for it or when it finishes something worth keeping, and anything running on a schedule leaves its result here. Nothing on this page can be replied to.") }}</p>
|
||||
|
||||
{# Reports became shareable and this filter arrived with them: a feed that
|
||||
quietly grew somebody else's work with no way to see only theirs would be
|
||||
@@ -22,7 +18,7 @@
|
||||
|
||||
<form method="get" action="/reports" class="btn-row" style="margin-bottom: var(--sp-5)">
|
||||
<input class="input" type="search" name="q" value="{{ q }}" style="flex: 1"
|
||||
placeholder="Search reports…">
|
||||
placeholder="{{ t('Search reports…') }}">
|
||||
<button class="btn" type="submit">{{ icon("search", "icon--sm") }} Search</button>
|
||||
{% if q %}<a class="btn btn--sm" href="/reports">Clear</a>{% endif %}
|
||||
</form>
|
||||
@@ -56,9 +52,9 @@
|
||||
</div>
|
||||
</div>
|
||||
<div class="btn-row">
|
||||
{% if report.error %}<span class="badge badge--warning">failed</span>{% endif %}
|
||||
{% if report.source == "schedule" %}<span class="badge">scheduled</span>{% endif %}
|
||||
{% if report.unread %}<span class="badge badge--leaf">new</span>{% endif %}
|
||||
{% if report.error %}<span class="badge badge--warning">{{ t("failed") }}</span>{% endif %}
|
||||
{% if report.source == "schedule" %}<span class="badge">{{ t("scheduled") }}</span>{% endif %}
|
||||
{% if report.unread %}<span class="badge badge--leaf">{{ t("new") }}</span>{% endif %}
|
||||
</div>
|
||||
</li>
|
||||
{% endfor %}
|
||||
|
||||
Reference in New Issue
Block a user