The interface speaks Slovak
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -16,6 +16,7 @@ from lembas.services import steps as steps_service
|
||||
from lembas.services import tool_labels
|
||||
from lembas.services.markdown import highlight_tokens
|
||||
from lembas.services.reasoning import format_duration
|
||||
from lembas.web import i18n
|
||||
|
||||
TEMPLATE_DIR = Path(__file__).parent / "templates"
|
||||
STATIC_DIR = Path(__file__).parent / "static"
|
||||
@@ -24,6 +25,21 @@ templates = Jinja2Templates(directory=str(TEMPLATE_DIR))
|
||||
templates.env.trim_blocks = True
|
||||
templates.env.lstrip_blocks = True
|
||||
|
||||
# {{ t("Save") }} -> "Uložiť". A global and not a context value, for the reason
|
||||
# `brand` below gives at length: `render()` is bypassed by 25 direct
|
||||
# `TemplateResponse` calls and 8 `get_template().render()` calls, and the second
|
||||
# group is the SSE frame path, which has no `Request` at all. The active language
|
||||
# comes from a ContextVar rather than from here, because a global is bound once at
|
||||
# import and the language is per person -- see `web/i18n/__init__.py`.
|
||||
templates.env.globals["t"] = i18n.t
|
||||
# For `<html lang>` and `<html dir>`, answered from one place so a right-to-left
|
||||
# language added later is not forgotten in the template.
|
||||
templates.env.globals["language"] = i18n.active
|
||||
templates.env.globals["text_direction"] = i18n.direction
|
||||
# {{ stamp(row.created_at, "%d %B %Y") }} -> a date whose month name is in the
|
||||
# reader's language. `strftime` alone is C-locale English on every page.
|
||||
templates.env.globals["stamp"] = i18n.stamp
|
||||
|
||||
# {{ message.reasoning_ms | duration }} -> "8 seconds"
|
||||
templates.env.filters["duration"] = format_duration
|
||||
|
||||
|
||||
Reference in New Issue
Block a user