Add registration toggle and password change; genericise deploy
Two things the running instance needed. **Registration toggle.** Admin -> General, backed by a new settings table group rather than the environment. LEMBAS_ALLOW_SIGNUP now seeds only the initial value: once an administrator saves the setting, the stored value wins. The alternative -- environment always winning -- means a toggle in the UI silently reverts on the next restart, which is worse than not offering one. Closing registration also removes the "Create one" link from the sign-in page, so the link never leads somewhere that refuses. **Password change**, on the user settings page. Changing a password revokes every other session and immediately re-issues a cookie for the current one: if the reason for the change is that somebody else knows the password, leaving their session alive defeats the point, but signing the user out of the tab they are standing in is merely rude. **deploy/ is now host-agnostic.** This repository is public, so the unit and vhost became templates with __PREFIX__ / __SITE_HOST__ / __APP_PORT__ substituted at install time, and every path, hostname and port moved to environment variables. REPO_URL defaults to the checkout's own origin so a fork deploys itself. Machine-specific values belong in private notes, not here -- CLAUDE.md now says so. 83 tests, ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -2,9 +2,17 @@
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from fastapi import APIRouter, Body
|
||||
import logging
|
||||
|
||||
from fastapi import APIRouter, Body, Form, Request, status
|
||||
from fastapi.responses import RedirectResponse, Response
|
||||
|
||||
from lembas.api.deps import Db, RequiredUser
|
||||
from lembas.config import settings
|
||||
from lembas.security.passwords import hash_password, validate_password, verify_password
|
||||
from lembas.security.sessions import COOKIE_NAME, create_session, revoke_all_for_user
|
||||
|
||||
log = logging.getLogger(__name__)
|
||||
|
||||
router = APIRouter(prefix="/api/preferences", tags=["preferences"])
|
||||
|
||||
@@ -27,3 +35,68 @@ async def set_theme(db: Db, user: RequiredUser, theme: str = Body(..., embed=Tru
|
||||
user.settings_json = {**(user.settings_json or {}), "theme": theme}
|
||||
db.commit()
|
||||
return {"ok": True, "theme": theme}
|
||||
|
||||
|
||||
@router.post("/password")
|
||||
async def change_password(
|
||||
request: Request,
|
||||
db: Db,
|
||||
user: RequiredUser,
|
||||
current_password: str = Form(...),
|
||||
new_password: str = Form(...),
|
||||
confirm_password: str = Form(...),
|
||||
) -> Response:
|
||||
"""Change your own password.
|
||||
|
||||
Every other session is revoked on success. If the reason for changing a
|
||||
password is that someone else knows it, leaving their session alive would
|
||||
defeat the point.
|
||||
"""
|
||||
|
||||
def back(message: str, ok: bool = False) -> Response:
|
||||
from urllib.parse import quote
|
||||
|
||||
field = "saved" if ok else "error"
|
||||
return RedirectResponse(
|
||||
f"/settings?{field}={quote(message)}", status_code=status.HTTP_303_SEE_OTHER
|
||||
)
|
||||
|
||||
if not verify_password(current_password, user.password_hash):
|
||||
log.info("failed password change for %s: current password wrong", user.email)
|
||||
return back("Your current password is not correct.")
|
||||
|
||||
if new_password != confirm_password:
|
||||
return back("The new passwords do not match.")
|
||||
|
||||
if (problem := validate_password(new_password)) is not None:
|
||||
return back(problem)
|
||||
|
||||
if verify_password(new_password, user.password_hash):
|
||||
return back("That is already your password.")
|
||||
|
||||
user.password_hash = hash_password(new_password)
|
||||
db.commit()
|
||||
|
||||
revoke_all_for_user(db, user)
|
||||
token = create_session(
|
||||
db,
|
||||
user,
|
||||
user_agent=request.headers.get("user-agent", ""),
|
||||
ip_address=request.client.host if request.client else "",
|
||||
)
|
||||
log.info("password changed for %s; other sessions revoked", user.email)
|
||||
|
||||
# revoke_all_for_user killed this session too, so hand back a fresh cookie
|
||||
# -- otherwise changing your password would sign you out of the tab you are
|
||||
# standing in.
|
||||
response = back("Password changed. Any other sessions have been signed out.", ok=True)
|
||||
response.set_cookie(
|
||||
COOKIE_NAME,
|
||||
token,
|
||||
max_age=settings.session_ttl,
|
||||
httponly=True,
|
||||
samesite="lax",
|
||||
secure=False,
|
||||
path="/",
|
||||
)
|
||||
return response
|
||||
|
||||
Reference in New Issue
Block a user