Files, open beside the conversation
A third side panel, built the way the terminal is and filled the way the inspector is: tabs holding open files. Project files over SFTP in an agent chat; notes, skills, knowledge documents, this chat's text attachments and its own scratch document everywhere. Read with pygments, edited in a plain textarea, saved with a conflict check. A bug found on the way in, and the reason this needed its own read path. `ssh.read_file` ends in `clean_output`, which strips ANSI escapes and decodes with errors="replace" -- right for the output of a command, and fatal for an editor: open a file containing an escape byte, press Save, and you have silently rewritten it with the escapes gone and every undecodable byte replaced by U+FFFD. `read_text`/`write_text` decode strictly, report binary rather than mangling it, carry an mtime:size token for a file that moved underneath, and refuse an oversize write rather than truncating -- `write_file` truncates because a model is told how many bytes it wrote, and somebody pressing Save is not. The model-facing pair is untouched: what it returns is a contract a model has been shown. A truncated read opens read-only for the mirror-image reason. Six sources go through one dispatch table, for the reason tool_labels.py is a table: six independently written permission checks is how one ends up written slightly differently, and that failure looks like editing somebody else's note. A save on a project file bypasses agent/policy.py, which makes it the fourth documented exception to "the modes do not govern the keyboard" and the first that writes. Same argument as the terminal panel -- whoever owns the credential could write the file with scp -- but the consequence is larger and is now said out loud rather than left to be inferred. The model opens tabs from the file tools it was already calling, so no new schema and no tokens. It never brings one to the front: an agent reads forty files in a long reply, and taking the screen each time would drag somebody through all of them and lose any edit in progress. Only the strip is streamed, guarded on truthiness so the frame can never blank itself -- an empty one would close every open tab, the approval card you could press twice with the sign reversed. Both halves are settled on the server, which is why canvas.js needs no guard against a swap at all. No vendored editor. CodeMirror 6 needs a bundler, which is hard rule 1; CodeMirror 5 would be a larger payload than xterm on every page, and xterm is the one heavy dependency precisely because it loads only where it can be used. So: server-rendered highlighting for reading, a textarea for writing, and the panel says there is no colour while you type rather than pretending. Also here: a scratch document per chat, with `scratch_write` at RISK_READ on plan_update's argument, and a test pinning the three numbers that decide a panel's width -- LAYOUT_BOUNDS drops an unknown variable silently, so a panel missing from it has a drag handle that works and forgets. Driven under a DOM stub and against the running application. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -19,7 +19,7 @@ import nh3
|
||||
from markdown_it import MarkdownIt
|
||||
from pygments import highlight
|
||||
from pygments.formatters import HtmlFormatter
|
||||
from pygments.lexers import get_lexer_by_name, guess_lexer
|
||||
from pygments.lexers import get_lexer_by_name, get_lexer_for_filename, guess_lexer
|
||||
from pygments.util import ClassNotFound
|
||||
|
||||
# Class-based highlighting; the colours come from theme tokens in chat.css, so
|
||||
@@ -95,6 +95,43 @@ def _render_fence(tokens, idx, _options, _env) -> str:
|
||||
)
|
||||
|
||||
|
||||
def highlight_code(text: str, filename: str = "") -> str:
|
||||
"""A whole file, class-highlighted, for the canvas panel to read.
|
||||
|
||||
Here rather than in a module of its own because `markdown.py` is where
|
||||
pygments lives and `_FORMATTER` is already configured: a second formatter
|
||||
would mean a second set of class names and a second thing to theme, and the
|
||||
`.pg-*` rules would then be right about code fences and wrong about files.
|
||||
|
||||
Pygments' `HtmlFormatter` escapes what it is given, which is what makes this
|
||||
the one call the canvas templates mark `|safe`. The content came off
|
||||
somebody else's disk, so that property is the whole of the argument -- if
|
||||
the lexer cannot be found the text is escaped by hand instead, never passed
|
||||
through.
|
||||
|
||||
Chooses by filename, because that is what the canvas has: a lexer guessed
|
||||
from contents is confidently wrong on short files, and there is no fence
|
||||
info string here to read a language out of.
|
||||
"""
|
||||
if not text:
|
||||
return ""
|
||||
|
||||
lexer = None
|
||||
if filename:
|
||||
try:
|
||||
lexer = get_lexer_for_filename(filename, stripall=False)
|
||||
except (ClassNotFound, ValueError):
|
||||
lexer = None
|
||||
if lexer is None and len(text) > 200:
|
||||
try:
|
||||
lexer = guess_lexer(text)
|
||||
except (ClassNotFound, ValueError):
|
||||
lexer = None
|
||||
|
||||
body = nh3.clean_text(text) if lexer is None else highlight(text, lexer, _FORMATTER)
|
||||
return f'<pre class="canvas__code"><code>{body}</code></pre>'
|
||||
|
||||
|
||||
@functools.lru_cache(maxsize=1)
|
||||
def _parser() -> MarkdownIt:
|
||||
md = MarkdownIt("commonmark", {"linkify": True, "typographer": False})
|
||||
|
||||
Reference in New Issue
Block a user