"""Groups, permissions and model access control."""
from __future__ import annotations
import pytest
from fastapi.testclient import TestClient
from sqlalchemy import select
from lembas.db.models import Chat, Connection, Group, Model, User
from lembas.security import permissions
from lembas.services import chat as chat_service
from lembas.services import settings_store
from lembas.services.crypto import encrypt
@pytest.fixture
def admin(client: TestClient, registered) -> None:
"""The registered fixture already makes an administrator."""
return None
@pytest.fixture
def plain_user(client: TestClient, db, registered) -> User:
"""A second, non-admin account. Leaves the client signed in as them."""
client.post("/auth/logout", follow_redirects=False)
client.post(
"/auth/register",
data={"name": "Sam", "email": "sam@shire.test", "password": "potatoes-po-ta-toes"},
follow_redirects=False,
)
return db.scalar(select(User).where(User.email == "sam@shire.test"))
def _connection(db) -> Connection:
connection = Connection(
name="Test", base_url="http://127.0.0.1:1", api_key_encrypted=encrypt("")
)
db.add(connection)
db.commit()
return connection
def _model(db, model_id: str, **kwargs) -> Model:
model = Model(connection_id=_connection(db).id, model_id=model_id, **kwargs)
db.add(model)
db.commit()
return model
# --- Permission resolution ---------------------------------------------------
def test_admins_get_everything(db, registered):
admin_user = db.scalar(select(User).where(User.role == "admin"))
assert all(permissions.resolve(db, admin_user).values())
def test_signed_out_gets_nothing(db):
assert not any(permissions.resolve(db, None).values())
def test_plain_user_gets_the_baseline(db, plain_user):
resolved = permissions.resolve(db, plain_user)
assert resolved["chat.create"] is True
# Off in the baseline by default.
assert resolved["chat.params"] is False
def test_a_group_widens_permissions(db, plain_user):
group = Group(name="Power users", permissions_json={"chat.params": True})
group.users = [plain_user]
db.add(group)
db.commit()
assert permissions.resolve(db, plain_user)["chat.params"] is True
def test_groups_union_rather_than_override(db, plain_user):
"""A second group can only ever add. Absent means 'no opinion', not 'deny'."""
db.add_all(
[
Group(name="A", permissions_json={"chat.params": True}, users=[plain_user]),
Group(name="B", permissions_json={}, users=[plain_user]),
]
)
db.commit()
assert permissions.resolve(db, plain_user)["chat.params"] is True
def test_baseline_can_be_narrowed_instance_wide(db, plain_user):
settings_store.update(db, {"default_permissions": {"chat.create": False}})
assert permissions.resolve(db, plain_user)["chat.create"] is False
def test_a_group_can_grant_back_what_the_baseline_removed(db, plain_user):
settings_store.update(db, {"default_permissions": {"chat.create": False}})
db.add(Group(name="Writers", permissions_json={"chat.create": True}, users=[plain_user]))
db.commit()
assert permissions.resolve(db, plain_user)["chat.create"] is True
# --- Enforcement through the API ---------------------------------------------
def test_creating_a_chat_is_refused_without_permission(client: TestClient, db, plain_user):
settings_store.update(db, {"default_permissions": {"chat.create": False}})
assert client.post("/api/chats/start", data={"content": "hi"}).status_code == 403
assert db.scalar(select(Chat)) is None
def test_folder_routes_are_refused_without_permission(client: TestClient, db, plain_user):
settings_store.update(db, {"default_permissions": {"folder.manage": False}})
assert client.post("/api/folders", data={"name": "Nope"}).status_code == 403
def test_changing_sampling_is_refused_without_permission(
client: TestClient, db, plain_user, make_chat
):
_model(db, "test-model")
chat_id = make_chat(email="sam@shire.test")
response = client.patch(f"/api/chats/{chat_id}", data={"temperature": "0.9"})
assert response.status_code == 403
def test_sampling_is_allowed_once_a_group_grants_it(client: TestClient, db, plain_user, make_chat):
_model(db, "test-model")
db.add(Group(name="Tuners", permissions_json={"chat.params": True}, users=[plain_user]))
db.commit()
chat_id = make_chat(email="sam@shire.test")
assert client.patch(f"/api/chats/{chat_id}", data={"temperature": "0.9"}).status_code == 204
chat = db.get(Chat, chat_id)
db.refresh(chat)
assert chat.params_json["temperature"] == 0.9
@pytest.mark.parametrize(
("field", "value"),
[("temperature", "5"), ("top_p", "-1"), ("max_tokens", "0"), ("temperature", "abc")],
)
def test_out_of_range_parameters_are_dropped_not_clamped(
client: TestClient, db, registered, field, value
, make_chat):
"""Silently changing what someone typed is worse than ignoring it."""
_model(db, "test-model")
chat_id = make_chat()
client.patch(f"/api/chats/{chat_id}", data={field: value})
chat = db.get(Chat, chat_id)
db.refresh(chat)
assert field not in (chat.params_json or {})
def test_an_empty_parameter_clears_it(client: TestClient, db, registered, make_chat):
_model(db, "test-model")
chat_id = make_chat()
client.patch(f"/api/chats/{chat_id}", data={"temperature": "0.7"})
client.patch(f"/api/chats/{chat_id}", data={"temperature": ""})
chat = db.get(Chat, chat_id)
db.refresh(chat)
assert chat.params_json["temperature"] is None
# --- Model access ------------------------------------------------------------
def test_public_models_are_visible_to_everyone(db, plain_user):
_model(db, "open-model", public=True)
assert [m.model_id for m in permissions.models_visible_to(db, plain_user)] == ["open-model"]
def test_restricted_models_are_hidden_without_a_group(db, plain_user):
_model(db, "secret-model", public=False)
assert permissions.models_visible_to(db, plain_user) == []
def test_a_group_grants_access_to_a_restricted_model(db, plain_user):
model = _model(db, "secret-model", public=False)
group = Group(name="Insiders", users=[plain_user], models=[model])
db.add(group)
db.commit()
assert [m.model_id for m in permissions.models_visible_to(db, plain_user)] == ["secret-model"]
def test_admins_see_restricted_models(db, registered):
_model(db, "secret-model", public=False)
admin_user = db.scalar(select(User).where(User.role == "admin"))
assert [m.model_id for m in permissions.models_visible_to(db, admin_user)] == ["secret-model"]
def test_disabled_models_are_hidden_from_everyone(db, registered):
_model(db, "off-model", enabled=False)
admin_user = db.scalar(select(User).where(User.role == "admin"))
assert permissions.models_visible_to(db, admin_user) == []
def test_switching_to_an_inaccessible_model_is_refused(
client: TestClient, db, plain_user, make_chat
):
"""The picker is not the security boundary; a crafted request must fail."""
_model(db, "open-model", public=True)
_model(db, "secret-model", public=False)
chat_id = make_chat(email="sam@shire.test")
response = client.patch(f"/api/chats/{chat_id}", data={"model_id": "secret-model"})
assert response.status_code == 403
chat = db.get(Chat, chat_id)
db.refresh(chat)
assert chat.model_id == "open-model"
def test_model_select_permission_is_required_to_switch(
client: TestClient, db, plain_user, make_chat
):
_model(db, "a-model", public=True)
_model(db, "b-model", public=True)
settings_store.update(db, {"default_permissions": {"chat.model_select": False}})
chat_id = make_chat(email="sam@shire.test")
assert client.patch(f"/api/chats/{chat_id}", data={"model_id": "b-model"}).status_code == 403
# --- Ordering and defaults ---------------------------------------------------
def test_pinning_does_not_reorder_the_picker(db, registered):
"""Pinning is a sidebar shortcut. A picker whose order silently differs from
the admin screen is just confusing."""
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="ordinary", position=0),
Model(connection_id=connection.id, model_id="favourite", position=9, pinned=True),
]
)
db.commit()
admin_user = db.scalar(select(User).where(User.role == "admin"))
assert [m.model_id for m in chat_service.available_models(db, admin_user)] == [
"ordinary",
"favourite",
]
def test_position_decides_order_among_unpinned(db, registered):
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="second", position=1),
Model(connection_id=connection.id, model_id="first", position=0),
]
)
db.commit()
admin_user = db.scalar(select(User).where(User.role == "admin"))
assert [m.model_id for m in chat_service.available_models(db, admin_user)] == [
"first",
"second",
]
def test_instance_default_model_is_used_for_new_chats(client: TestClient, db, registered):
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="first", position=0),
Model(connection_id=connection.id, model_id="chosen", position=5),
]
)
db.commit()
settings_store.update(db, {"default_model": "chosen"})
client.post("/api/chats/start", data={"content": "hi"})
assert db.scalar(select(Chat)).model_id == "chosen"
def test_a_users_own_default_beats_the_instance_default(client: TestClient, db, plain_user):
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="instance-pick", position=0),
Model(connection_id=connection.id, model_id="my-pick", position=5),
]
)
db.commit()
settings_store.update(db, {"default_model": "instance-pick"})
client.post("/api/preferences/default-model", data={"model_id": "my-pick"})
client.post("/api/chats/start", data={"content": "hi"})
assert db.scalar(select(Chat)).model_id == "my-pick"
def test_an_unreachable_default_falls_through(db, plain_user):
"""A default the user has lost access to must not produce a dead chat."""
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="allowed", position=0, public=True),
Model(connection_id=connection.id, model_id="gone", position=1, public=False),
]
)
db.commit()
settings_store.update(db, {"default_model": "gone"})
assert chat_service.default_model(db, plain_user)[0] == "allowed"
def test_choosing_an_inaccessible_default_is_refused(client: TestClient, db, plain_user):
_model(db, "secret-model", public=False)
response = client.post(
"/api/preferences/default-model", data={"model_id": "secret-model"}, follow_redirects=False
)
assert "error=" in response.headers["location"]
db.refresh(plain_user)
assert "default_model" not in (plain_user.settings_json or {})
# --- Admin guards ------------------------------------------------------------
def test_ordinary_users_cannot_reach_user_administration(client: TestClient, db, plain_user):
for path in ("/admin/users", "/admin/groups", "/admin/models"):
assert client.get(path, follow_redirects=False).status_code == 403, path
def test_the_last_administrator_cannot_be_demoted(client: TestClient, db, registered):
admin_user = db.scalar(select(User).where(User.role == "admin"))
response = client.post(
f"/admin/users/{admin_user.id}",
data={"name": admin_user.name, "role": "user", "active": "true"},
follow_redirects=False,
)
assert "only+administrator" in response.headers["location"]
db.refresh(admin_user)
assert admin_user.role == "admin"
def test_you_cannot_delete_your_own_account(client: TestClient, db, registered):
admin_user = db.scalar(select(User).where(User.role == "admin"))
response = client.post(
f"/admin/users/{admin_user.id}/delete", follow_redirects=False
)
assert "your+own+account" in response.headers["location"]
assert db.get(User, admin_user.id) is not None
def test_deactivating_a_user_revokes_their_sessions(client: TestClient, db, registered):
"""Otherwise the change only lands when their cookie happens to expire."""
other = TestClient(client.app)
other.post(
"/auth/register",
data={"name": "Sam", "email": "sam@shire.test", "password": "potatoes-po-ta-toes"},
follow_redirects=False,
)
assert other.get("/chat", follow_redirects=False).status_code == 200
target = db.scalar(select(User).where(User.email == "sam@shire.test"))
client.post(
f"/admin/users/{target.id}",
data={"name": target.name, "role": "user"}, # `active` absent means off
follow_redirects=False,
)
assert other.get("/chat", follow_redirects=False).status_code == 303
def test_a_pinned_model_appears_once_in_the_picker(client: TestClient, db, registered, make_chat):
"""Two options with the same value, both selected, is not a picker."""
connection = _connection(db)
db.add_all(
[
Model(connection_id=connection.id, model_id="favourite", pinned=True, position=0),
Model(connection_id=connection.id, model_id="ordinary", position=1),
]
)
db.commit()
chat_id = make_chat()
page = client.get(f"/chat/{chat_id}").text
assert page.count('