HomerandClaude Opus 5
28390095a9
The sidebar was a 280px panel laid over the page below the phone breakpoint, opened from first paint, with the only control that closed it underneath it -- and that control existed on /chat and on none of the seven other pages carrying a sidebar, Settings included. It starts closed at that width now, slides, dims the page behind it, and closes by tapping beside it, by Escape, or by its own button, which is inside the drawer where it can be reached. Everything a finger has to hit was 36px, or 28 for renaming a chat, every action on a message and every panel's close button. Raising --control-h under a coarse pointer is the only fix that reaches all forty of them, which is what that token is for. The row and message actions were also hover-only, so on a phone they did not exist at all. Installing: the splash and the browser chrome follow the instance's theme rather than always being Moria's near-black; there are screenshots, so the install offer is a dialog rather than a one-line bar; a new release no longer takes over a page somebody is reading; the notification badge is a silhouette rather than a grey square; and a browser rotating its own subscription no longer ends notifications for good. Every request now says it is happening -- nothing did before, so anything slower than a few milliseconds looked like a click that had not registered. A chat can be archived. The column has been filtered on in four places since folders arrived and written by nothing, which is what made it look built. chat.css may contain media queries. The ban protected the composer toolbar from being "fixed" with a breakpoint; that guarantee is asserted directly now, and the old test would have passed a version of the file that wrapped the toolbar without one. scripts/shoot.py is the instrument all of this was found with: it renders a page through TestClient into a real headless browser at a real size and refuses to run if an asset URL was left pointing at testserver. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
267 lines
11 KiB
Python
267 lines
11 KiB
Python
"""Installing as an app, and the composer's single send/stop button."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from fastapi.testclient import TestClient
|
|
|
|
from lembas.services import settings_store
|
|
from lembas.web.templating import STATIC_DIR
|
|
|
|
|
|
# --- Manifest ----------------------------------------------------------------
|
|
def test_the_manifest_is_readable_when_signed_out(client: TestClient):
|
|
"""A browser fetches the manifest outside any page's session."""
|
|
response = client.get("/manifest.webmanifest")
|
|
assert response.status_code == 200
|
|
assert response.headers["content-type"].startswith("application/manifest+json")
|
|
|
|
|
|
def test_the_manifest_carries_the_instance_name(client: TestClient, db, registered):
|
|
"""The name moved to /admin/customization with the rest of the identity."""
|
|
client.post(
|
|
"/admin/customization/identity",
|
|
data={"instance_name": "Rivendell", "tagline": ""},
|
|
follow_redirects=False,
|
|
)
|
|
assert client.get("/manifest.webmanifest").json()["name"] == "Rivendell"
|
|
|
|
|
|
def test_the_manifest_offers_a_maskable_icon(client: TestClient):
|
|
"""Without one, Android crops the corners off the wafer."""
|
|
icons = client.get("/manifest.webmanifest").json()["icons"]
|
|
assert any(icon["purpose"] == "maskable" for icon in icons)
|
|
assert any(icon["sizes"] == "512x512" and icon["purpose"] == "any" for icon in icons)
|
|
|
|
|
|
def test_every_manifest_icon_exists(client: TestClient):
|
|
for icon in client.get("/manifest.webmanifest").json()["icons"]:
|
|
assert client.get(icon["src"]).status_code == 200, icon["src"]
|
|
|
|
|
|
def test_the_manifest_starts_at_the_chat(client: TestClient):
|
|
payload = client.get("/manifest.webmanifest").json()
|
|
assert payload["start_url"] == "/chat"
|
|
assert payload["scope"] == "/"
|
|
assert payload["display"] == "standalone"
|
|
|
|
|
|
# --- Service worker ----------------------------------------------------------
|
|
def test_the_worker_is_served_from_the_root(client: TestClient):
|
|
"""A worker under /static/js/ would have scope /static/js/ and control
|
|
nothing."""
|
|
response = client.get("/sw.js")
|
|
assert response.status_code == 200
|
|
assert response.headers["content-type"].startswith("text/javascript")
|
|
|
|
|
|
def test_the_worker_is_never_cached(client: TestClient):
|
|
"""A stale worker keeps serving a stale cache."""
|
|
assert "no-store" in client.get("/sw.js").headers["cache-control"]
|
|
|
|
|
|
def test_the_worker_leaves_the_api_alone():
|
|
"""The reply stream, the unread poll and attachment downloads all live
|
|
under /api/. A cached response on any of them is at best stale."""
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
assert '"/api/"' in source
|
|
assert "text/event-stream" in source
|
|
|
|
|
|
def test_every_precached_asset_exists(client: TestClient):
|
|
"""addAll is all-or-nothing in most implementations, and a missing entry is
|
|
invisible until someone opens the developer tools."""
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
shell = source.split("var SHELL = [", 1)[1].split("];", 1)[0]
|
|
paths = [line.strip().strip('",') for line in shell.splitlines() if '"' in line]
|
|
|
|
assert paths
|
|
for path in paths:
|
|
assert client.get(path).status_code == 200, path
|
|
|
|
|
|
def test_the_offline_page_stands_on_its_own(client: TestClient):
|
|
"""Cached at install time, so it must render with no user and no chats."""
|
|
response = client.get("/offline")
|
|
assert response.status_code == 200
|
|
assert 'class="sidebar' not in response.text
|
|
assert 'id="thread' not in response.text
|
|
|
|
|
|
def test_the_page_links_the_manifest_and_the_apple_icon(client: TestClient, registered):
|
|
page = client.get("/chat").text
|
|
assert 'rel="manifest"' in page
|
|
assert 'rel="apple-touch-icon"' in page
|
|
assert 'name="theme-color"' in page
|
|
|
|
|
|
# --- Send and Stop -----------------------------------------------------------
|
|
def test_the_hidden_attribute_wins_over_component_styles():
|
|
"""`.btn` is display: inline-flex, which beats the browser's own
|
|
`[hidden] { display: none }`. Without this rule a button hidden from
|
|
JavaScript stays on screen -- which is how Stop came to sit permanently
|
|
beside Send."""
|
|
css = (STATIC_DIR / "css" / "app.css").read_text()
|
|
assert "[hidden]" in css
|
|
assert "display: none !important" in css
|
|
|
|
|
|
def test_the_composer_has_exactly_one_send_button(client: TestClient, db, registered):
|
|
"""One button that becomes Stop, not two that take turns being hidden."""
|
|
_add_a_model(db)
|
|
page = client.get("/chat").text
|
|
assert page.count("data-composer-action") == 1
|
|
|
|
|
|
def test_the_send_button_carries_both_icons(client: TestClient, db, registered):
|
|
"""Rendered together and chosen in CSS, so the swap costs no layout and
|
|
cannot flash an empty button."""
|
|
_add_a_model(db)
|
|
page = client.get("/chat").text
|
|
assert "composer__icon--send" in page
|
|
assert "composer__icon--stop" in page
|
|
|
|
|
|
def test_the_composer_starts_in_the_send_state(client: TestClient, db, registered):
|
|
_add_a_model(db)
|
|
assert 'data-composer-action="send"' in client.get("/chat").text
|
|
|
|
|
|
def _add_a_model(db):
|
|
from lembas.db.models import Connection, Model
|
|
|
|
connection = Connection(name="c", base_url="http://127.0.0.1:1", api_key_encrypted="")
|
|
db.add(connection)
|
|
db.commit()
|
|
db.add(Model(connection_id=connection.id, model_id="m"))
|
|
db.commit()
|
|
|
|
|
|
# --- The icons themselves ----------------------------------------------------
|
|
def test_the_generated_icons_are_committed():
|
|
"""They come from scripts/build_artwork.py and are committed like the SVGs;
|
|
the running application has no rasteriser."""
|
|
for name in (
|
|
"icon-192.png",
|
|
"icon-512.png",
|
|
"icon-maskable-512.png",
|
|
"apple-touch-icon-180.png",
|
|
):
|
|
path = Path(STATIC_DIR) / "img" / name
|
|
assert path.exists(), name
|
|
assert path.read_bytes()[:8] == b"\x89PNG\r\n\x1a\n", name
|
|
|
|
|
|
def test_the_mic_appears_only_when_dictation_is_configured(
|
|
client: TestClient, db, registered
|
|
):
|
|
_add_a_model(db)
|
|
assert "data-mic" not in client.get("/chat").text
|
|
|
|
settings_store.update(
|
|
db,
|
|
{"stt_enabled": True, "stt_base_url": "http://stt"},
|
|
key=settings_store.AUDIO,
|
|
)
|
|
assert "data-mic" in client.get("/chat").text
|
|
|
|
|
|
# --- The manifest, beyond the installability minimum -------------------------
|
|
def test_the_manifest_offers_launcher_shortcuts(client: TestClient):
|
|
"""A long-press on the launcher icon should reach the three places worth
|
|
going to directly. Absent, it offers nothing."""
|
|
payload = client.get("/manifest.webmanifest").json()
|
|
urls = {s["url"] for s in payload["shortcuts"]}
|
|
assert urls == {"/chat", "/messages", "/scheduled"}
|
|
|
|
|
|
def test_the_manifest_identity_matches_where_it_starts(client: TestClient):
|
|
"""`id` was "/", which serves nothing but a redirect, while the app started
|
|
at /chat. Legal, and it reads as a mistake to anyone comparing the two."""
|
|
payload = client.get("/manifest.webmanifest").json()
|
|
assert payload["id"] == payload["start_url"]
|
|
|
|
|
|
def test_the_manifest_declares_the_rest_of_the_quality_set(client: TestClient):
|
|
payload = client.get("/manifest.webmanifest").json()
|
|
for key in ("orientation", "categories", "lang", "dir",
|
|
"display_override", "launch_handler"):
|
|
assert key in payload, key
|
|
|
|
|
|
def test_the_splash_follows_the_instance_theme(client: TestClient, monkeypatch):
|
|
"""It was Moria's near-black whatever the instance was set up in, so a
|
|
parchment instance installed to a phone flashed dark and opened light --
|
|
and `THEME_COLOUR["shire"]` sat beside it, defined and read by nothing."""
|
|
from lembas.config import settings
|
|
|
|
monkeypatch.setattr(settings, "default_theme", "shire")
|
|
payload = client.get("/manifest.webmanifest").json()
|
|
assert payload["theme_color"] == "#F6F1E4"
|
|
assert payload["background_color"] == payload["theme_color"]
|
|
|
|
|
|
def test_the_page_paints_the_right_chrome_before_any_script_runs(client, registered):
|
|
"""One unscoped `theme-color` meant a light-theme reader got dark browser
|
|
chrome on every load until the deferred script corrected it."""
|
|
page = client.get("/chat").text
|
|
assert 'media="(prefers-color-scheme: dark)"' in page
|
|
assert 'media="(prefers-color-scheme: light)"' in page
|
|
|
|
|
|
# --- The worker --------------------------------------------------------------
|
|
def test_the_worker_does_not_take_over_a_page_being_read():
|
|
"""It called skipWaiting() unconditionally, so a release replaced the
|
|
assets under an open tab mid-session. It waits to be asked now."""
|
|
import re
|
|
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
# Comments stripped first: the install handler explains at length that it
|
|
# deliberately does not call this, and a test that reads prose would fail
|
|
# on the explanation for the fix.
|
|
code = re.sub(r"/\*.*?\*/", "", source, flags=re.S)
|
|
code = re.sub(r"//[^\n]*", "", code)
|
|
install = code.split('addEventListener("install"', 1)[1].split("addEventListener(", 1)[0]
|
|
assert "skipWaiting" not in install
|
|
assert 'event.data.type === "SKIP_WAITING"' in code
|
|
|
|
|
|
def test_the_worker_survives_a_rotated_subscription():
|
|
"""A browser replacing a subscription on its own is the normal way push
|
|
stops working, and nothing anywhere said so."""
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
assert "pushsubscriptionchange" in source
|
|
|
|
|
|
def test_the_badge_is_not_the_full_colour_icon():
|
|
"""A badge is drawn as a mask -- the device keeps the alpha and throws the
|
|
colour away -- so an icon opaque to its edges renders as a grey square."""
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
assert 'badge: "/static/img/badge-72.png"' in source
|
|
badge = Path(STATIC_DIR) / "img" / "badge-72.png"
|
|
assert badge.exists() and badge.read_bytes()[:8] == b"\x89PNG\r\n\x1a\n"
|
|
|
|
|
|
def test_the_two_icons_a_device_crops_are_cached():
|
|
source = (STATIC_DIR / "js" / "sw.js").read_text()
|
|
shell = source.split("var SHELL = [", 1)[1].split("];", 1)[0]
|
|
assert "icon-maskable-512.png" in shell
|
|
assert "apple-touch-icon-180.png" in shell
|
|
|
|
|
|
# --- The window's own edges --------------------------------------------------
|
|
def test_the_page_asks_for_the_whole_screen_and_then_pays_for_it(client, registered):
|
|
"""`viewport-fit=cover` is what makes `env(safe-area-inset-*)` resolve to
|
|
anything but zero, and `black-translucent` below it is what puts the page
|
|
under the status bar in the first place. One without the other is a topbar
|
|
beneath the clock."""
|
|
page = client.get("/chat").text
|
|
assert "viewport-fit=cover" in page
|
|
|
|
css = (STATIC_DIR / "css" / "tokens.css").read_text()
|
|
assert "safe-area-inset-top" in css
|
|
app = (STATIC_DIR / "css" / "app.css").read_text()
|
|
assert "var(--safe-top)" in app
|
|
assert "var(--safe-bottom)" in app
|