2f09d8363d
Nothing in LLeMbas ever happened on its own. Every reply was downstream of
somebody pressing Send, and the one exception -- jobs.wake, waking a chat when a
background job finishes -- was downstream of a command they had run. PLAN.md
never listed scheduling as unbuilt because services/chat.py:618 had recorded it
as a decision: "a scheduler is a whole new concern for a single-worker
application". This is that concern, taken on deliberately, plus the two places
its output goes.
Reports first, because it is useful with no scheduling at all. A report is not a
Chat with one Message in it: it has no turns and no reply, it is read top to
bottom, and it must be writable with no chat behind it -- being the fallback for
a run whose own chat has gone. As a Chat it would need a sidebar row per daily
report, a title that regenerates itself, a composer to suppress and a bubble with
a rewind button around something that is not a turn. The section's character is
enforced by absence: nothing under reports/ includes the composer or renders
chat/_message.html, so there is no sse-connect anywhere and nothing on those
pages *can* start a generation. The test reads that off the OpenAPI schema, not
by walking app.routes -- this FastAPI keeps an included router wrapped rather
than flattening it, so the walk finds nothing and the assertion passes for the
wrong reason.
rule.py is pure, total, and was finished before anything called it. No session,
no wall clock, nothing that raises: validate clamps what it recognises, drops
what it does not, and answers {} for prose -- at which point the caller shows the
manual form. It had to be that way because the compile step's output is model
output that becomes a *timer*, which is the sharpest case of hard rule 6 here.
The invariant, pinned: anything validate accepts has a computable next
occurrence. A schedule that can never fire looks exactly like a working one on
every screen it appears on.
Wall-clock and elapsed time are kept apart because they mean different things.
at.times are wall-clock in the owner's zone, so 15:00 stays 15:00 across a
daylight-saving change -- that is what "every Monday at 3PM" means. every is
elapsed real time, so six hours stays six hours across a 23- or 25-hour day --
that is what a timer means. Conflating them gets one of the two wrong twice a
year. A time inside the spring-forward gap fires at the first minute that exists;
left to zoneinfo's own resolution it lands an hour away wearing a wall-clock time
that did not happen, and a daily 02:30 report vanishing once a year on a machine
nobody watches is the failure this file is arranged around.
The ticker claims and commits *before* it fires. The other order is a hot loop: a
firing that raises is retried every tick for ever against whatever it was that
failed, and the only symptom is load. Its blanket except is copied from the
terminal reaper for a sharper reason -- a ticker that dies on one bad row stops
every schedule on the instance and says nothing at all. No request fails, no
reply errors, no dot appears. The reports simply stop.
Three rules that look like bugs from outside: a firing arriving while the chat is
still answering queues rather than starting a second reply, and past max_queued
is skipped with the reason on the row; Run now does not advance next_fire_at, or
testing a schedule silently consumes the run it was testing; resuming recomputes
from now, or a schedule paused for a month fires the instant it comes back, once
per occurrence it missed. Catching up lives in the sweep and not in a startup
hook, because a suspended host and a long stall reproduce "its time passed while
nothing was running" with no restart to hang one on.
services/wake.py is the lock discipline extracted rather than copied. A finished
job and a due schedule are the same problem, and both depend on there being no
await between the running_for check and the writes; two lock dictionaries for one
invariant is how one of them drifts. jobs.wake is now a caller that supplies
wording, and _completion_text stayed exactly where it was because tool.background
quotes its opening sentence.
A scheduled run has no reader, so ask_user is withdrawn from resolve_tools rather
than merely discouraged in core.unattended -- a rule living only in a system
message is one a page the model just read can argue with, and a parked question
holds the reply for the whole approval_timeout with nobody to answer it. For the
same reason a task chat may not be an agent chat in v1: Manual, Edit and Plan all
stop to ask on RISK_EXECUTE, so the only two outcomes would be unattended
execution and a reply that stalls. That deserves its own pass.
Messages is bounded in the request and unbounded on disk. Only the latest chunk
is sent; everything else stays exactly where it was written. Nothing is folded
into text and nothing is deleted -- the visible conversation is identical either
way, so destroying the older rows would buy only disk, against being irreversible
and losing every attachment and tool call in the range, and it would contradict
the rule compaction already holds. should_compact refuses this kind for the
matching reason: two mechanisms narrowing one transcript is how a summary ends up
summarising a summary. The history route is the mirror of thread_tail and keeps
its four properties; the fifth is its own, that prepending moves the scroll
position, so app.js records scrollHeight before the swap and adds the difference
back after.
An empty Chat.kind meant "both sides of the switch" and had been read as "no
filter" since there were only two of them. The sidebar passes "" precisely when
agent chats are switched off -- so the moment a third kind existed, every task
chat and every Messages conversation appeared in somebody's ordinary chat list,
on exactly the instances whose owners would never think to look. KINDS stays the
two-sided fork, because set_sidebar_kind validates against it and a third entry
there makes the tree filterable to a side with no button to leave it; ALL_KINDS
is what a row may be. Both narrowings are pinned, because they are two
implementations of one rule and only one of them is SQL.
Per-user timezone had to exist for any of this: harness.py:179 was telling every
reader the *server's* idea of the date, which is survivable while the answer is
prose and stops being survivable the moment somebody says "every Monday at 3" and
something has to work out when that is.
Three things were caught by a test being wrong rather than by the code being
wrong. The task-chat "no composer" assertions were passing against a page
rendering its no-models-configured branch. A permission test asserted the same
thing twice because the administrator bypasses every permission. And every
Messages test passed with default_model never called, because none of them
configured a model -- so the pair it returns was being assigned straight to
model_id, and SQLite refuses a tuple in a String column. The fixtures now say why
they exist.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
160 lines
5.1 KiB
Python
160 lines
5.1 KiB
Python
"""Reports: filing a finished piece of work, and finding it again.
|
|
|
|
A report is written and read; it is never answered. That is the whole shape of
|
|
the thing, and it is why this store is deliberately thinner than
|
|
`services/library/`: there is no sharing, because a report is a record of what
|
|
somebody's own model did on their behalf, and no revisions, because a report
|
|
describes a moment rather than a document being worked on.
|
|
|
|
`sharing.visible_to` is therefore absent on purpose rather than forgotten. If
|
|
reports ever become shareable, `RESOURCE_TYPES` is where that starts, and every
|
|
listing here has to go through the helper -- six independently written
|
|
permission checks is how one of them ends up written slightly differently.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
|
|
from sqlalchemy import func, select
|
|
from sqlalchemy.orm import Session as DBSession
|
|
|
|
from lembas.db.models import SOURCE_MANUAL, SOURCES, Report, User
|
|
from lembas.services.library.fts import search_ids
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
INDEX = "reports_fts"
|
|
|
|
MAX_TITLE_CHARS = 300
|
|
MAX_SUMMARY_CHARS = 500
|
|
MAX_BODY_CHARS = 60_000
|
|
SNIPPET_CHARS = 400
|
|
|
|
|
|
def visible(user: User | None):
|
|
"""Every report this person owns.
|
|
|
|
Takes no session because it builds a query rather than running one, and
|
|
takes `None` to mean nobody so an unauthenticated caller gets an empty
|
|
result instead of an exception -- the same shape `sharing.visible_to` has,
|
|
so a later move to shared reports is a change of one line here.
|
|
"""
|
|
if user is None:
|
|
return select(Report).where(Report.id.is_(None))
|
|
return select(Report).where(Report.owner_id == user.id)
|
|
|
|
|
|
def get(db: DBSession, report_id: str, user: User | None) -> Report | None:
|
|
report = db.get(Report, report_id)
|
|
if report is None or user is None or report.owner_id != user.id:
|
|
return None
|
|
return report
|
|
|
|
|
|
def recent(db: DBSession, user: User | None, *, limit: int = 20) -> list[Report]:
|
|
return list(db.scalars(visible(user).order_by(Report.created_at.desc()).limit(limit)))
|
|
|
|
|
|
def search(db: DBSession, user: User | None, needle: str, *, limit: int = 20) -> list[Report]:
|
|
"""Reports matching `needle`, best match first.
|
|
|
|
Ids come back from FTS and the rows are re-ordered by hit position, exactly
|
|
as the library stores do -- the index knows about ranking and the ORM query
|
|
knows about ownership, and neither is asked to do the other's job.
|
|
"""
|
|
hits = search_ids(db, INDEX, needle, limit=limit * 4)
|
|
if not hits:
|
|
return []
|
|
order = {hit.id: position for position, hit in enumerate(hits)}
|
|
rows = list(db.scalars(visible(user).where(Report.id.in_(list(order)))))
|
|
rows.sort(key=lambda report: order.get(report.id, len(order)))
|
|
return rows[:limit]
|
|
|
|
|
|
def unread_count(db: DBSession, user: User | None) -> int:
|
|
if user is None:
|
|
return 0
|
|
return int(
|
|
db.scalar(
|
|
select(func.count()).select_from(Report).where(
|
|
Report.owner_id == user.id, Report.unread.is_(True)
|
|
)
|
|
)
|
|
or 0
|
|
)
|
|
|
|
|
|
def _first_line(body: str) -> str:
|
|
"""A summary for a model that did not write one.
|
|
|
|
Markdown headings are stripped rather than shown: a list of reports all
|
|
beginning "# " reads as a bug, and the heading is nearly always the title
|
|
again.
|
|
"""
|
|
for line in (body or "").splitlines():
|
|
stripped = line.strip().lstrip("#").strip()
|
|
if stripped:
|
|
return stripped[:MAX_SUMMARY_CHARS]
|
|
return ""
|
|
|
|
|
|
def create(
|
|
db: DBSession,
|
|
*,
|
|
owner: User,
|
|
title: str,
|
|
body: str,
|
|
summary: str = "",
|
|
source: str = SOURCE_MANUAL,
|
|
source_id: str = "",
|
|
schedule_id: str = "",
|
|
model_id: str = "",
|
|
error: str = "",
|
|
unread: bool = True,
|
|
) -> Report:
|
|
"""File a report.
|
|
|
|
Trimming happens here rather than at the column so an over-long write from
|
|
a tool is filed short with everything else intact, instead of failing the
|
|
turn -- the rule `memories` already follows.
|
|
|
|
`unread` defaults to True because every caller that matters is something
|
|
that happened without the reader present. A report somebody typed themselves
|
|
passes False.
|
|
"""
|
|
report = Report(
|
|
owner_id=owner.id,
|
|
title=(title.strip() or "Untitled report")[:MAX_TITLE_CHARS],
|
|
summary=(summary.strip() or _first_line(body))[:MAX_SUMMARY_CHARS],
|
|
body=(body or "").strip()[:MAX_BODY_CHARS],
|
|
source=source if source in SOURCES else SOURCE_MANUAL,
|
|
source_id=source_id or "",
|
|
schedule_id=schedule_id or "",
|
|
model_id=model_id or "",
|
|
error=error or "",
|
|
unread=unread,
|
|
)
|
|
db.add(report)
|
|
db.commit()
|
|
return report
|
|
|
|
|
|
def mark_read(db: DBSession, report: Report) -> Report:
|
|
if report.unread:
|
|
report.unread = False
|
|
db.commit()
|
|
return report
|
|
|
|
|
|
def delete(db: DBSession, report: Report) -> None:
|
|
db.delete(report)
|
|
db.commit()
|
|
|
|
|
|
def snippet(report: Report) -> str:
|
|
text = (report.summary or report.body or "").strip()
|
|
if len(text) <= SNIPPET_CHARS:
|
|
return text
|
|
return text[:SNIPPET_CHARS].rstrip() + "…"
|