Jaroslav Beneš
816f2ae957
Six smaller things, all of them about the interface not saying what is true.
The @ button only ever inserted the character, which the @ key already does
without a button. It becomes the scope menu: what this chat may use, switched
off per chat. Chat.scope_json is filtered inside resolve_tools AFTER the
capability, permission and instance gates -- exactly as chat.knowledge_bases
narrows knowledge_search -- so a crafted POST turning something on reaches a
tool the gates already removed, and there is a test that writes the column
directly to prove it. Absent means on, for every key, so "why is this off?" has
one answer. It is keyed on the gate rather than the tool name, so notes is one
switch rather than five. The switches carry no role="menuitem", deliberately:
ui.js closes a picker when a menuitem is clicked, which is right for an action
menu and wrong for a list you want to set several of -- which is why the menu
needs no JavaScript at all. Typing @ is untouched.
With no skills, nothing should mention them. tool.skills was gated on the family
alone, so somebody with an empty library was told "the list below gives each
one's name" above no list, handed skill_get, and watched the model spend a round
finding out. It requires skills now; the writing half moved to
tool.skills_write, which is deliberately not gated, because saving the first one
is what somebody with none most needs. And core.tool_list finally reads
tool_names, which had been resolved and documented with no fragment using it.
The composer's toolbar is one row again. .composer__actions is last in the DOM
with margin-left:auto, so the moment an agent chat added a connection, a
directory and a mode, Send and the microphone dropped to a second line.
chat.css has no media queries by design and the fix is not to add one:
.composer__context is the single child allowed to shrink and scroll sideways.
There is a test asserting the file still contains no @media.
The effort picker shows the level in force. "Effort: default" named no level and
was true of nothing in particular; chat.resolved_effort is the chat's own value
and build_request reads the same field, so what is shown is what is sent. The
model's default is a seed, copied onto the row at creation and on a model
change, and never consulted at request time -- a fallback would resurrect it
underneath a cleared effort and make "off" silently do nothing. "off" is a
sentinel and not an empty value, because start_chat declares Form("") and cannot
tell absent from empty: with value="" the reader picks off and gets high.
Alt+M dictates, Alt+R reads the last reply aloud, Ctrl+Enter sends from
anywhere. All three click the button that already does the job, so audio.js
keeps its one delegated listener. Alt+M and not Alt+D, which is the address bar
in Chrome and Firefox. Ctrl+Enter never means Stop -- Send and Stop are the same
element, and Esc already stops. Driven under a DOM stub before committing, per
the rule in CLAUDE.md, and tests/test_commands_js.py pins that every key has a
row in SHORTCUTS, since /help reads that list.
And the memory tooling, which had seven defects. The worst: memory_forget was a
case-insensitive substring first-match delete with nothing warning about it, so
forgetting "coffee" against "Drinks coffee black" and "Allergic to coffee"
silently removed whichever was older -- a wrong deletion nobody would ever find
out about, from a tool whose description invited exactly the short fragment that
misfires. It matches exactly first, then by substring, and refuses an ambiguous
one while naming what it matched. add() refuses an exact duplicate. The
at-the-limit refusal no longer tells the model to delete one to make room: past
the block's budget it is not shown all of them and would be guessing, which
feeds straight back into the first defect. And context.memories no longer claims
the memories "still apply", which nothing checks and which taught a model to
trust a stale one over what the person had just said.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
61 lines
2.3 KiB
Python
61 lines
2.3 KiB
Python
"""The keyboard, checked without a runtime.
|
|
|
|
There is no JavaScript test runner here and hard rule 1 keeps Node out of the
|
|
project, so the behaviour is driven by hand under a DOM stub before committing.
|
|
What can be pinned in the suite is the invariant the file states about itself:
|
|
`/help` reads `SHORTCUTS`, so a shortcut that is not in that list is a shortcut
|
|
nobody can discover. That is the direction this actually rots -- a key gets
|
|
added to the handler and the sheet is forgotten.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
import lembas
|
|
|
|
SOURCE = (
|
|
Path(lembas.__file__).parent / "web/static/js/commands.js"
|
|
).read_text(encoding="utf-8")
|
|
|
|
# The declared list, up to where the command table starts.
|
|
SHORTCUTS = SOURCE[SOURCE.index("var SHORTCUTS") : SOURCE.index("/* --- The table")]
|
|
|
|
|
|
def test_every_letter_key_the_handlers_match_is_described():
|
|
letters = {match[-1] for match in re.findall(r'event\.code === "Key([A-Z])"', SOURCE)}
|
|
assert letters, "no letter shortcuts found at all, which means the regex is wrong"
|
|
|
|
missing = [letter for letter in sorted(letters) if f"+ {letter}" not in SHORTCUTS]
|
|
assert not missing, f"not in /help: {missing}"
|
|
|
|
|
|
def test_the_three_new_ones_are_there():
|
|
"""Named rather than only counted, because the point of them is being
|
|
findable: Enter already sends *inside the box*, and dictation and read-aloud
|
|
were click-only."""
|
|
assert "Ctrl/⌘ + Enter" in SHORTCUTS
|
|
assert "Alt + M" in SHORTCUTS
|
|
assert "Alt + R" in SHORTCUTS
|
|
|
|
|
|
def test_dictation_is_not_bound_to_alt_d():
|
|
"""Alt+D is the address bar in Chrome and Firefox on Windows and Linux. A
|
|
shortcut the browser wins is a shortcut that looks broken."""
|
|
assert 'event.code === "KeyD"' not in SOURCE
|
|
|
|
|
|
def test_the_shortcuts_are_matched_on_the_physical_key():
|
|
"""The file's own stated rule: `event.code`, so a Dvorak or Slovak layout
|
|
gets the same shortcuts rather than whichever letters sit there."""
|
|
assert "event.key ===" not in SOURCE
|
|
|
|
|
|
def test_send_from_anywhere_never_means_stop():
|
|
"""Send and Stop are the same element. Ctrl+Enter reaching it while it is
|
|
Stop would abandon a reply on a key people press to send -- and Esc already
|
|
stops."""
|
|
window = SOURCE[SOURCE.index('event.code === "Enter"') :][:600]
|
|
assert 'composerAction === "send"' in window
|