59739cc7fd
The second audit pass. Four things, and the first two were reported. The Prompts page put a screen of variables and a screen of preview above the editor, so the tabs began two screens down and switching one had to drag the whole page to be any use -- and on a short tab it could not drag far enough, leaving the panel stranded above a screenful of nothing. Editor first, reference after, bar sticky. Custom themes were three fixed slots: fifty-seven empty colour boxes on a fresh instance and no way to make a fourth theme. One block per theme plus a blank one, colours behind a disclosure. Both measured rather than argued about -- rendered through TestClient and driven under headless Chromium, where the tab bar moved 385->642px before and does not move now, and the themes page went from 5495px to 2820px. Asking where generated images go found the other two. Deleting a chat cascades to the attachment rows and leaves every file on disk; the helper written for exactly that was called from one place, and it was not the delete button, a schedule's chat, a helper's chat or deleting an account. Underneath it, `claim` bound message_id and never chat_id, so anything picked before a chat existed kept an empty chat_id forever -- which six readers filter on, so those files were also unnamed in the prompt, unopenable in the canvas, and invisible to the one caller the cleanup had. And folders nest now. The route has handled parent_id since folders existed, with a cycle guard and a depth cap the move path never applied; the sidebar has always drawn a tree. Nothing could ask for one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
233 lines
8.2 KiB
Python
233 lines
8.2 KiB
Python
"""Making, changing and stopping a schedule.
|
|
|
|
The row-level half: what the routes and the tools both need, so neither has its
|
|
own idea of what creating a schedule involves. `services/schedule/` holds the
|
|
machinery — when it next comes due, and what happens when it does.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from datetime import UTC, datetime
|
|
|
|
from sqlalchemy import func, select
|
|
from sqlalchemy.orm import Session as DBSession
|
|
|
|
from lembas.db.models import (
|
|
KIND_TASK,
|
|
ORIGIN_USER,
|
|
ORIGINS,
|
|
TARGET_CHAT,
|
|
TARGETS,
|
|
Chat,
|
|
Schedule,
|
|
User,
|
|
)
|
|
from lembas.services import settings_store
|
|
from lembas.services.schedule import clock
|
|
from lembas.services.schedule import rule as rule_service
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
MAX_TITLE_CHARS = 200
|
|
MAX_INSTRUCTION_CHARS = 8000
|
|
|
|
|
|
class ScheduleError(Exception):
|
|
"""Something a person needs told, in words they can act on."""
|
|
|
|
|
|
def visible(user: User | None):
|
|
if user is None:
|
|
return select(Schedule).where(Schedule.id.is_(None))
|
|
return select(Schedule).where(Schedule.user_id == user.id)
|
|
|
|
|
|
def get(db: DBSession, schedule_id: str, user: User | None) -> Schedule | None:
|
|
schedule = db.get(Schedule, schedule_id)
|
|
if schedule is None or user is None or schedule.user_id != user.id:
|
|
return None
|
|
return schedule
|
|
|
|
|
|
def for_chat(db: DBSession, chat: Chat) -> Schedule | None:
|
|
"""The schedule a task chat belongs to, if any."""
|
|
return db.scalars(select(Schedule).where(Schedule.chat_id == chat.id)).first()
|
|
|
|
|
|
def count_for(db: DBSession, user: User) -> int:
|
|
return int(
|
|
db.scalar(
|
|
select(func.count()).select_from(Schedule).where(Schedule.user_id == user.id)
|
|
)
|
|
or 0
|
|
)
|
|
|
|
|
|
def create(
|
|
db: DBSession,
|
|
*,
|
|
owner: User,
|
|
title: str,
|
|
instruction: str,
|
|
rule: dict,
|
|
request: str = "",
|
|
target: str = TARGET_CHAT,
|
|
model_id: str = "",
|
|
origin: str = ORIGIN_USER,
|
|
) -> Schedule:
|
|
"""Write a schedule and the chat it fires into.
|
|
|
|
**The chat is created here, with the schedule**, and this is the one place
|
|
"chats are created lazily" is deliberately bent. That rule exists so an
|
|
opened-and-abandoned chat never appears in the sidebar; a task chat is not
|
|
opened and abandoned, because creating it *is* the act. It also has to exist
|
|
before the first firing, which may be days away and will have nobody
|
|
present to make one.
|
|
|
|
A task chat is never `KIND_AGENT`. Scheduling one would mean running
|
|
commands on a timer with nobody watching — and since every mode except Auto
|
|
stalls waiting for an approval that will not come, the only two outcomes are
|
|
"unattended execution" and "does nothing". That deserves its own pass with a
|
|
mode built for it, not a flag here.
|
|
"""
|
|
clean = rule_service.validate(rule)
|
|
if not clean:
|
|
raise ScheduleError(
|
|
"That does not describe a time anything could run at. "
|
|
"Say when it should happen — a date and time, or how often."
|
|
)
|
|
if rule_service.next_after(clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)) is None:
|
|
# Belt and braces over `validate`'s own invariant. A schedule that can
|
|
# never fire looks exactly like a working one on every screen it appears
|
|
# on, so it is refused at the only moment somebody is present to be told.
|
|
raise ScheduleError("That schedule has no next run — its time has already passed.")
|
|
|
|
limit = int(settings_store.schedules(db).get("max_per_user") or 20)
|
|
if count_for(db, owner) >= limit:
|
|
raise ScheduleError(
|
|
f"You already have {limit} schedules, which is the most this instance allows. "
|
|
"Remove one before adding another."
|
|
)
|
|
|
|
chat = Chat(
|
|
user_id=owner.id,
|
|
kind=KIND_TASK,
|
|
title=(title.strip() or "Scheduled task")[:MAX_TITLE_CHARS],
|
|
model_id=model_id or "",
|
|
# Said on the row as well as implied by the kind. `tools.unattended`
|
|
# reads both, because the column was added to a table that already held
|
|
# task chats and a backfill cannot know which they were -- but every one
|
|
# written from here on says so for itself, which is what the check on
|
|
# the kind is there to stop being needed forever.
|
|
unattended=True,
|
|
)
|
|
db.add(chat)
|
|
db.flush()
|
|
|
|
schedule = Schedule(
|
|
user_id=owner.id,
|
|
title=(title.strip() or "Scheduled task")[:MAX_TITLE_CHARS],
|
|
request=(request or "").strip()[:MAX_INSTRUCTION_CHARS],
|
|
instruction=(instruction or "").strip()[:MAX_INSTRUCTION_CHARS],
|
|
rule_json=clean,
|
|
target=target if target in TARGETS else TARGET_CHAT,
|
|
chat_id=chat.id,
|
|
model_id=model_id or "",
|
|
origin=origin if origin in ORIGINS else ORIGIN_USER,
|
|
enabled=True,
|
|
next_fire_at=rule_service.next_after(
|
|
clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)
|
|
),
|
|
compiled_at=datetime.now(tz=UTC),
|
|
)
|
|
db.add(schedule)
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def update(
|
|
db: DBSession,
|
|
schedule: Schedule,
|
|
*,
|
|
owner: User,
|
|
title: str | None = None,
|
|
instruction: str | None = None,
|
|
rule: dict | None = None,
|
|
target: str | None = None,
|
|
) -> Schedule:
|
|
"""Change a schedule. Absent arguments are left alone."""
|
|
if title is not None and title.strip():
|
|
schedule.title = title.strip()[:MAX_TITLE_CHARS]
|
|
if instruction is not None:
|
|
schedule.instruction = instruction.strip()[:MAX_INSTRUCTION_CHARS]
|
|
if target is not None and target in TARGETS:
|
|
schedule.target = target
|
|
if rule is not None:
|
|
clean = rule_service.validate(rule)
|
|
if not clean:
|
|
raise ScheduleError(
|
|
"That does not describe a time anything could run at. "
|
|
"Say when it should happen — a date and time, or how often."
|
|
)
|
|
schedule.rule_json = clean
|
|
# Recomputed from now, and the count restarted: an edited schedule is a
|
|
# new intention, and carrying the old `fired_count` into a new `count`
|
|
# would silently spend most of it before the first run.
|
|
schedule.fired_count = 0
|
|
schedule.next_fire_at = rule_service.next_after(
|
|
clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)
|
|
)
|
|
if schedule.next_fire_at is None:
|
|
raise ScheduleError("That schedule has no next run — its time has already passed.")
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def set_enabled(db: DBSession, schedule: Schedule, *, owner: User, enabled: bool) -> Schedule:
|
|
"""Pause or resume.
|
|
|
|
**Resuming recomputes from now**, never from the stored value. A schedule
|
|
paused for a month would otherwise come back due — and with catching-up in
|
|
the sweep, it would fire the moment it was switched on, having decided it
|
|
was owed a run from four weeks ago.
|
|
"""
|
|
schedule.enabled = bool(enabled)
|
|
if enabled:
|
|
schedule.last_error = ""
|
|
schedule.next_fire_at = rule_service.next_after(
|
|
schedule.rule_json or {},
|
|
datetime.now(tz=UTC),
|
|
zone=clock.zone_for(owner),
|
|
fired=schedule.fired_count or 0,
|
|
)
|
|
if schedule.next_fire_at is None:
|
|
schedule.enabled = False
|
|
schedule.last_error = "There are no runs left in this schedule."
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def delete(db: DBSession, schedule: Schedule, *, keep_chat: bool = True) -> None:
|
|
"""Remove a schedule, and by default keep its transcript.
|
|
|
|
Keeping is the default because deleting a conversation as a side effect of
|
|
removing a timer is exactly the destructive default this codebase avoids
|
|
elsewhere. The chat becomes an ordinary one so it is reachable again — a
|
|
`KIND_TASK` chat with no schedule behind it would be in no list at all.
|
|
"""
|
|
chat = db.get(Chat, schedule.chat_id) if schedule.chat_id else None
|
|
if chat is not None:
|
|
if keep_chat:
|
|
chat.kind = "chat"
|
|
else:
|
|
from lembas.services import chat as chat_service
|
|
|
|
chat_service.delete_chats(db, [chat])
|
|
db.delete(schedule)
|
|
db.commit()
|
|
|
|
|
|
def describe(schedule: Schedule, *, owner: User | None) -> str:
|
|
return rule_service.describe(schedule.rule_json or {}, zone=clock.zone_for(owner))
|