46066150d9
subagent_run gives a self-contained piece of work to a helper carrying the parent's connection, directory, model and effort, and hands its answer back as the tool result. The mechanism is the one scheduled runs already use -- a hidden chat, one turn, wake_chat, and a poll -- so tools, rounds, budgets, metrics and steps all work with no second implementation. The two alternatives were rejected where they had already been rejected once: a nested Generation is two replies writing one transcript, and a one-shot complete() has no tools, which schedule/runner.py records as useless for exactly this case. Every restriction is a property of the child's row, applied by resolve_tools after the gates, because a rule that lives in a system message is one a page the model just read can argue with. No questions, no recursion, nothing that writes unless the call asked for it and the parent's own mode would not have stopped first, and commands only from a fixed read-only list -- in every mode including Auto, because the task text can have come from a page. Withdrawing ask_user turned out to be half of "nobody is watching". An approval still built a card nobody could see and parked the reply until approval_timeout, which from every screen is the feature not working. Chat.unattended is the question now, and not the kind: _authorise answers with a refusal instead. A scheduled task's chat had the same hole and is covered by the same flag. Three bounds, counted where each is knowable: per reply on the parent's Generation, instance-wide in a set a restart clears, and per helper in settings of its own so one runs out of room long before the reply that asked. Past the clock the helper is stopped rather than abandoned, so a partial answer comes back with a sentence saying so. Also: four gates had shipped into the scope menu with no name, taking the first tool's label instead -- the canvas switch read "Canvas written". There is a test that refuses a family without one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
231 lines
8.1 KiB
Python
231 lines
8.1 KiB
Python
"""Making, changing and stopping a schedule.
|
|
|
|
The row-level half: what the routes and the tools both need, so neither has its
|
|
own idea of what creating a schedule involves. `services/schedule/` holds the
|
|
machinery — when it next comes due, and what happens when it does.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from datetime import UTC, datetime
|
|
|
|
from sqlalchemy import func, select
|
|
from sqlalchemy.orm import Session as DBSession
|
|
|
|
from lembas.db.models import (
|
|
KIND_TASK,
|
|
ORIGIN_USER,
|
|
ORIGINS,
|
|
TARGET_CHAT,
|
|
TARGETS,
|
|
Chat,
|
|
Schedule,
|
|
User,
|
|
)
|
|
from lembas.services import settings_store
|
|
from lembas.services.schedule import clock
|
|
from lembas.services.schedule import rule as rule_service
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
MAX_TITLE_CHARS = 200
|
|
MAX_INSTRUCTION_CHARS = 8000
|
|
|
|
|
|
class ScheduleError(Exception):
|
|
"""Something a person needs told, in words they can act on."""
|
|
|
|
|
|
def visible(user: User | None):
|
|
if user is None:
|
|
return select(Schedule).where(Schedule.id.is_(None))
|
|
return select(Schedule).where(Schedule.user_id == user.id)
|
|
|
|
|
|
def get(db: DBSession, schedule_id: str, user: User | None) -> Schedule | None:
|
|
schedule = db.get(Schedule, schedule_id)
|
|
if schedule is None or user is None or schedule.user_id != user.id:
|
|
return None
|
|
return schedule
|
|
|
|
|
|
def for_chat(db: DBSession, chat: Chat) -> Schedule | None:
|
|
"""The schedule a task chat belongs to, if any."""
|
|
return db.scalars(select(Schedule).where(Schedule.chat_id == chat.id)).first()
|
|
|
|
|
|
def count_for(db: DBSession, user: User) -> int:
|
|
return int(
|
|
db.scalar(
|
|
select(func.count()).select_from(Schedule).where(Schedule.user_id == user.id)
|
|
)
|
|
or 0
|
|
)
|
|
|
|
|
|
def create(
|
|
db: DBSession,
|
|
*,
|
|
owner: User,
|
|
title: str,
|
|
instruction: str,
|
|
rule: dict,
|
|
request: str = "",
|
|
target: str = TARGET_CHAT,
|
|
model_id: str = "",
|
|
origin: str = ORIGIN_USER,
|
|
) -> Schedule:
|
|
"""Write a schedule and the chat it fires into.
|
|
|
|
**The chat is created here, with the schedule**, and this is the one place
|
|
"chats are created lazily" is deliberately bent. That rule exists so an
|
|
opened-and-abandoned chat never appears in the sidebar; a task chat is not
|
|
opened and abandoned, because creating it *is* the act. It also has to exist
|
|
before the first firing, which may be days away and will have nobody
|
|
present to make one.
|
|
|
|
A task chat is never `KIND_AGENT`. Scheduling one would mean running
|
|
commands on a timer with nobody watching — and since every mode except Auto
|
|
stalls waiting for an approval that will not come, the only two outcomes are
|
|
"unattended execution" and "does nothing". That deserves its own pass with a
|
|
mode built for it, not a flag here.
|
|
"""
|
|
clean = rule_service.validate(rule)
|
|
if not clean:
|
|
raise ScheduleError(
|
|
"That does not describe a time anything could run at. "
|
|
"Say when it should happen — a date and time, or how often."
|
|
)
|
|
if rule_service.next_after(clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)) is None:
|
|
# Belt and braces over `validate`'s own invariant. A schedule that can
|
|
# never fire looks exactly like a working one on every screen it appears
|
|
# on, so it is refused at the only moment somebody is present to be told.
|
|
raise ScheduleError("That schedule has no next run — its time has already passed.")
|
|
|
|
limit = int(settings_store.schedules(db).get("max_per_user") or 20)
|
|
if count_for(db, owner) >= limit:
|
|
raise ScheduleError(
|
|
f"You already have {limit} schedules, which is the most this instance allows. "
|
|
"Remove one before adding another."
|
|
)
|
|
|
|
chat = Chat(
|
|
user_id=owner.id,
|
|
kind=KIND_TASK,
|
|
title=(title.strip() or "Scheduled task")[:MAX_TITLE_CHARS],
|
|
model_id=model_id or "",
|
|
# Said on the row as well as implied by the kind. `tools.unattended`
|
|
# reads both, because the column was added to a table that already held
|
|
# task chats and a backfill cannot know which they were -- but every one
|
|
# written from here on says so for itself, which is what the check on
|
|
# the kind is there to stop being needed forever.
|
|
unattended=True,
|
|
)
|
|
db.add(chat)
|
|
db.flush()
|
|
|
|
schedule = Schedule(
|
|
user_id=owner.id,
|
|
title=(title.strip() or "Scheduled task")[:MAX_TITLE_CHARS],
|
|
request=(request or "").strip()[:MAX_INSTRUCTION_CHARS],
|
|
instruction=(instruction or "").strip()[:MAX_INSTRUCTION_CHARS],
|
|
rule_json=clean,
|
|
target=target if target in TARGETS else TARGET_CHAT,
|
|
chat_id=chat.id,
|
|
model_id=model_id or "",
|
|
origin=origin if origin in ORIGINS else ORIGIN_USER,
|
|
enabled=True,
|
|
next_fire_at=rule_service.next_after(
|
|
clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)
|
|
),
|
|
compiled_at=datetime.now(tz=UTC),
|
|
)
|
|
db.add(schedule)
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def update(
|
|
db: DBSession,
|
|
schedule: Schedule,
|
|
*,
|
|
owner: User,
|
|
title: str | None = None,
|
|
instruction: str | None = None,
|
|
rule: dict | None = None,
|
|
target: str | None = None,
|
|
) -> Schedule:
|
|
"""Change a schedule. Absent arguments are left alone."""
|
|
if title is not None and title.strip():
|
|
schedule.title = title.strip()[:MAX_TITLE_CHARS]
|
|
if instruction is not None:
|
|
schedule.instruction = instruction.strip()[:MAX_INSTRUCTION_CHARS]
|
|
if target is not None and target in TARGETS:
|
|
schedule.target = target
|
|
if rule is not None:
|
|
clean = rule_service.validate(rule)
|
|
if not clean:
|
|
raise ScheduleError(
|
|
"That does not describe a time anything could run at. "
|
|
"Say when it should happen — a date and time, or how often."
|
|
)
|
|
schedule.rule_json = clean
|
|
# Recomputed from now, and the count restarted: an edited schedule is a
|
|
# new intention, and carrying the old `fired_count` into a new `count`
|
|
# would silently spend most of it before the first run.
|
|
schedule.fired_count = 0
|
|
schedule.next_fire_at = rule_service.next_after(
|
|
clean, datetime.now(tz=UTC), zone=clock.zone_for(owner)
|
|
)
|
|
if schedule.next_fire_at is None:
|
|
raise ScheduleError("That schedule has no next run — its time has already passed.")
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def set_enabled(db: DBSession, schedule: Schedule, *, owner: User, enabled: bool) -> Schedule:
|
|
"""Pause or resume.
|
|
|
|
**Resuming recomputes from now**, never from the stored value. A schedule
|
|
paused for a month would otherwise come back due — and with catching-up in
|
|
the sweep, it would fire the moment it was switched on, having decided it
|
|
was owed a run from four weeks ago.
|
|
"""
|
|
schedule.enabled = bool(enabled)
|
|
if enabled:
|
|
schedule.last_error = ""
|
|
schedule.next_fire_at = rule_service.next_after(
|
|
schedule.rule_json or {},
|
|
datetime.now(tz=UTC),
|
|
zone=clock.zone_for(owner),
|
|
fired=schedule.fired_count or 0,
|
|
)
|
|
if schedule.next_fire_at is None:
|
|
schedule.enabled = False
|
|
schedule.last_error = "There are no runs left in this schedule."
|
|
db.commit()
|
|
return schedule
|
|
|
|
|
|
def delete(db: DBSession, schedule: Schedule, *, keep_chat: bool = True) -> None:
|
|
"""Remove a schedule, and by default keep its transcript.
|
|
|
|
Keeping is the default because deleting a conversation as a side effect of
|
|
removing a timer is exactly the destructive default this codebase avoids
|
|
elsewhere. The chat becomes an ordinary one so it is reachable again — a
|
|
`KIND_TASK` chat with no schedule behind it would be in no list at all.
|
|
"""
|
|
chat = db.get(Chat, schedule.chat_id) if schedule.chat_id else None
|
|
if chat is not None:
|
|
if keep_chat:
|
|
chat.kind = "chat"
|
|
else:
|
|
db.delete(chat)
|
|
db.delete(schedule)
|
|
db.commit()
|
|
|
|
|
|
def describe(schedule: Schedule, *, owner: User | None) -> str:
|
|
return rule_service.describe(schedule.rule_json or {}, zone=clock.zone_for(owner))
|