HomerandClaude Opus 5
a16510aba8
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
75 lines
3.0 KiB
HTML
75 lines
3.0 KiB
HTML
{% from "_macros.html" import icon %}
|
|
{#
|
|
One file, read or edited.
|
|
|
|
A read/edit split rather than a highlighting editor, because there is no
|
|
vendored code editor and adding one would be a build step (hard rule 1) or a
|
|
payload larger than xterm's on every page in the application -- and xterm is
|
|
called out as the one heavy dependency precisely because it loads only on a
|
|
chat that can open a terminal.
|
|
|
|
So: pygments server-side for reading, and a plain <textarea> for writing. A
|
|
textarea's value is text by construction, which is the same argument as
|
|
"attachments are served, never linked" -- pick the shape where the failure
|
|
cannot happen rather than the shape where it has to be prevented.
|
|
|
|
`rendered` is the ONE `|safe` here. It is either pygments output, which
|
|
escapes what it is given, or render_markdown, which is the single path in this
|
|
application allowed to emit HTML.
|
|
#}
|
|
<div class="canvas__doc" x-data="{ editing: false }" data-canvas-doc="{{ doc.key }}">
|
|
|
|
{% if doc.binary %}
|
|
<p class="canvas__note">
|
|
{{ icon("warning", "icon--sm") }}
|
|
This does not look like text, so there is nothing to show and nothing that
|
|
could safely be saved back.
|
|
</p>
|
|
{% elif doc.truncated %}
|
|
<p class="canvas__note">
|
|
{{ icon("warning", "icon--sm") }}
|
|
Showing the beginning only. Saving from here would delete the rest, so this
|
|
one is read-only.
|
|
</p>
|
|
{% endif %}
|
|
|
|
{% if doc.editable %}
|
|
<div class="canvas__actions" x-show="!editing">
|
|
<button class="btn btn--sm" type="button"
|
|
@click="editing = true; $nextTick(() => $refs.editor.focus())">
|
|
{{ icon("pencil", "icon--sm") }} Edit
|
|
</button>
|
|
</div>
|
|
{% endif %}
|
|
|
|
<div class="canvas__view" {% if doc.editable %}x-show="!editing"{% endif %}>
|
|
{% if rendered %}
|
|
{{ rendered | safe }}
|
|
{% else %}
|
|
<p class="canvas__empty">{{ t("This file is empty.") }}</p>
|
|
{% endif %}
|
|
</div>
|
|
|
|
{% if doc.editable %}
|
|
<form class="canvas__form" x-show="editing" x-cloak
|
|
hx-post="/api/chats/{{ chat.id }}/canvas/save"
|
|
hx-target="#canvas-inner" hx-swap="innerHTML">
|
|
<input type="hidden" name="key" value="{{ doc.key }}">
|
|
{# What version this was opened at. The save compares it and refuses a file
|
|
that moved underneath, rather than overwriting somebody else's work. #}
|
|
<input type="hidden" name="revision" value="{{ doc.revision }}">
|
|
<label class="visually-hidden" for="canvas-editor">{{ doc.title }}</label>
|
|
<textarea class="canvas__editor" id="canvas-editor" name="text"
|
|
spellcheck="false" x-ref="editor"
|
|
data-canvas-editor>{{ doc.text }}</textarea>
|
|
<div class="canvas__actions">
|
|
<button class="btn btn--primary btn--sm" type="submit">
|
|
{{ icon("check", "icon--sm") }} Save
|
|
</button>
|
|
<button class="btn btn--sm" type="button" @click="editing = false">{{ t("Cancel") }}</button>
|
|
<span class="canvas__hint">{{ t("No colour while you type. Tab inserts a tab.") }}</span>
|
|
</div>
|
|
</form>
|
|
{% endif %}
|
|
</div>
|