HomerandClaude Opus 5
a16510aba8
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
41 lines
1.8 KiB
HTML
41 lines
1.8 KiB
HTML
{% from "_macros.html" import icon %}
|
|
{#
|
|
New chat, and New folder.
|
|
|
|
Its own partial because "New chat" changes with the Chat/Agent switch and this
|
|
row sits *outside* the tree the switch swaps -- above the scroll area, so it
|
|
does not scroll away. It arrives out of band instead, the move the `done`
|
|
frame already makes for the chat title.
|
|
|
|
It was not a partial to begin with, and the button went on saying "New chat"
|
|
after the switch moved to Agents while the tree beneath it showed agent chats.
|
|
Whether it worked was not the question: it said one thing and did another,
|
|
which is exactly the shape of failure the switch itself was arranged to avoid.
|
|
#}
|
|
{% if can.get("chat.create") or can.get("folder.manage") %}
|
|
<div class="sidebar__actions" id="sidebar-actions"
|
|
{% if oob %}hx-swap-oob="true"{% endif %}>
|
|
{% if can.get("chat.create") %}
|
|
{# Carries the side the switch is on, so this opens the new-chat screen
|
|
already on the right fork. #}
|
|
<a class="btn btn--primary btn--grow"
|
|
href="/chat{{ '?kind=agent' if sidebar_kind == 'agent' else '' }}">
|
|
{{ icon("plus", "icon--sm") }}
|
|
{{ "New agent chat" if sidebar_kind == "agent" else "New chat" }}
|
|
</a>
|
|
{% endif %}
|
|
{% if can.get("folder.manage") %}
|
|
{# Asks for the name rather than making "New folder" and leaving somebody to
|
|
find the rename. `data-prompt` writes the answer into hx-vals before the
|
|
request goes out; see ui.js for why this is not htmx's own hx-prompt. #}
|
|
<button class="btn btn--icon" hx-post="/api/folders" hx-swap="none"
|
|
data-prompt="What should this folder be called?"
|
|
data-prompt-title="{{ t('New folder') }}" data-prompt-field="name"
|
|
data-prompt-label="Create"
|
|
aria-label="{{ t('New folder') }}" title="{{ t('New folder') }}">
|
|
{{ icon("folder") }}
|
|
</button>
|
|
{% endif %}
|
|
</div>
|
|
{% endif %}
|