HomerandClaude Opus 5
a16510aba8
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
89 lines
3.5 KiB
HTML
89 lines
3.5 KiB
HTML
{% extends "admin/_layout.html" %}
|
|
{% from "_macros.html" import icon %}
|
|
{% set section = "groups" %}
|
|
|
|
{% block title %}Groups & permissions - {{ brand.name }}{% endblock %}
|
|
{% block heading %}Groups & permissions{% endblock %}
|
|
|
|
{% block admin_content %}
|
|
<p class="admin-lede">
|
|
Permissions are a <strong>{{ t("union") }}</strong>: everyone starts with the baseline
|
|
below, and each group they belong to can add more. A group never takes
|
|
something away, so being in a second group can only widen what someone can do —
|
|
which is what keeps “why can this person not do X?” answerable without
|
|
simulating every group they are in. Administrators bypass all of it.
|
|
</p>
|
|
|
|
{% if saved %}
|
|
<div class="alert alert--success">{{ icon("check", "icon--sm") }} <span>{{ saved }}</span></div>
|
|
{% endif %}
|
|
|
|
<section class="card">
|
|
<h2 class="card__title">{{ t("Baseline permissions") }}</h2>
|
|
<p class="card__lede">{{ t("What every signed-in user can do before any group is considered. Turn something off here and grant it through a group to make it opt-in.") }}</p>
|
|
|
|
<form method="post" action="/admin/permissions/defaults">
|
|
{% for section_name, defs in permission_groups.items() %}
|
|
<div class="field">
|
|
<span class="field__label">{{ section_name }}</span>
|
|
{% for definition in defs %}
|
|
<label class="checkbox perm-row">
|
|
<input type="checkbox" name="permission" value="{{ definition.key }}"
|
|
{{ 'checked' if baseline[definition.key] }}>
|
|
<span>
|
|
<strong>{{ definition.label }}</strong>
|
|
<span class="perm-row__desc">{{ definition.description }}</span>
|
|
</span>
|
|
</label>
|
|
{% endfor %}
|
|
</div>
|
|
{% endfor %}
|
|
<div class="btn-row"><button class="btn btn--primary" type="submit">{{ t("Save baseline") }}</button></div>
|
|
</form>
|
|
</section>
|
|
|
|
<h2 class="admin-section-title">
|
|
Groups <span class="badge">{{ groups|length }}</span>
|
|
</h2>
|
|
|
|
{#
|
|
Rows, not a form each. The old page rendered every group's full permission
|
|
grid, every member and every model on one screen -- fine for two groups and
|
|
unreadable at ten, which is the list-plus-detail rule the model admin already
|
|
follows.
|
|
#}
|
|
<div class="model-rows">
|
|
{% for group in groups %}
|
|
<a class="model-row" href="/admin/groups/{{ group.id }}">
|
|
<div class="model-row__main">
|
|
<span class="model-row__name">{{ group.name }}</span>
|
|
{% if group.description %}
|
|
<span class="model-row__id">{{ group.description }}</span>
|
|
{% endif %}
|
|
</div>
|
|
<div class="model-row__meta">
|
|
<span class="badge">{{ group.users | length }} member{{ '' if group.users|length == 1 else 's' }}</span>
|
|
{% if granted[group.id] %}
|
|
<span class="badge badge--leaf">+{{ granted[group.id] }} permission{{ '' if granted[group.id] == 1 else 's' }}</span>
|
|
{% endif %}
|
|
{% if group.limits_json %}<span class="badge">{{ t("quotas") }}</span>{% endif %}
|
|
</div>
|
|
</a>
|
|
{% else %}
|
|
<div class="empty" style="padding: var(--sp-8) 0">
|
|
<p class="empty__text">{{ t("No groups yet. Everybody gets the baseline above and nothing more.") }}</p>
|
|
</div>
|
|
{% endfor %}
|
|
</div>
|
|
|
|
<section class="card" style="margin-top: var(--sp-6)">
|
|
<form method="post" action="/admin/groups" class="btn-row">
|
|
<input class="input" name="name" placeholder="{{ t('New group name') }}" required
|
|
aria-label="{{ t('New group name') }}">
|
|
<button class="btn btn--primary" type="submit">
|
|
{{ icon("plus", "icon--sm") }} Create group
|
|
</button>
|
|
</form>
|
|
</section>
|
|
{% endblock %}
|