HomerandClaude Opus 5
a16510aba8
969 strings, an instance default and a per-person choice, and no half-done corner: the admin prose is translated too. Design and reasoning: LLeMbas.wiki/Translations. KEYED BY THE ENGLISH SENTENCE A missing entry renders the key, which is the English -- so an untranslated string looks as it always did, an English instance is byte-for-byte 1.6.0, and a half-finished catalogue is a half-translated page rather than a page of dotted key names. The cost is that editing an English sentence orphans its translation silently, which is what tests/test_translations.py asserts in both directions. No gettext: .po -> .mo is a build step and this project does not have one. A JINJA GLOBAL, AND THEREFORE A CONTEXTVAR `t()` is a global for the reason `brand` already documents -- render() is bypassed by 25 TemplateResponse calls and 8 get_template().render() calls, the latter being the SSE frames, which have no Request at all. A global is bound once at import and the language is per person, so the active language is a ContextVar set per request. 🚨 `get_current_user` had to become `async def`. FastAPI runs a sync dependency in a threadpool, and anyio copies the context in and discards it on the way out -- so the language was set where nothing could see it and every page rendered in the instance's language whatever anybody had chosen, with no error anywhere. NOT TRANSLATED, ON PURPOSE Everything a model reads: the 60 prompt fragments, and the dates in harness.py, schedule/runner.py and schedule/compile.py. Only `i18n.stamp` is localised, and only where a person reads it -- with the *format* translatable as well as the words, because "26. septembra 2026" is a different pattern rather than the same one with different words in it. A process locale is not an option: global, not thread-safe, two people's pages at once. A second fragment telling models to answer in the reader's language was written during this work and removed: `core.style` has said it since long before, and test_an_empty_override_turns_a_fragment_off caught the duplicate. THE BULK PASS 1213 sites wrapped by a one-off script that only touched patterns it could not misread. It got three wrong in a way that mattered -- `t('…')` inside `attr="…"` where the sentence held an apostrophe, closing the Jinja string and 500ing two pages whose partials no test renders. tests/test_translations.py now compiles all 110 templates. It also wrapped the product's own name, an SSH key header, a keystroke hint and an example URL, all taken back out: a string is not translatable just because it is a string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
51 lines
2.1 KiB
HTML
51 lines
2.1 KiB
HTML
{% from "_macros.html" import icon %}
|
|
{#
|
|
The file moved between being opened and being saved -- another editor, a
|
|
build, a checkout.
|
|
|
|
Three answers, and none of them is silent. Never save over somebody else's
|
|
change without saying so; never throw away what was typed here without saying
|
|
so either. What you wrote is held in the form below, so Overwrite is one
|
|
click and not a retype.
|
|
|
|
Sent at 200 rather than 409 on purpose: htmx does not swap an error status,
|
|
and a card offering three buttons cannot be offered from a response the panel
|
|
will not render.
|
|
#}
|
|
<div class="canvas__conflict">
|
|
<div class="alert alert--warning" role="alert">
|
|
{{ icon("warning", "alert__icon") }}
|
|
<span>
|
|
<strong>{{ conflict.title }}</strong> changed after you opened it, so
|
|
nothing was written. Your version is below.
|
|
</span>
|
|
</div>
|
|
|
|
<details class="canvas__theirs">
|
|
<summary>{{ t("What is there now") }}</summary>
|
|
<pre class="canvas__code"><code>{{ conflict.text }}</code></pre>
|
|
</details>
|
|
|
|
<form class="canvas__form"
|
|
hx-post="/api/chats/{{ chat.id }}/canvas/save"
|
|
hx-target="#canvas-inner" hx-swap="innerHTML">
|
|
<input type="hidden" name="key" value="{{ conflict.key }}">
|
|
{# Deliberately empty. An empty token is what tells `_check_stamp` to write
|
|
regardless, which is exactly what Overwrite means -- somebody has now
|
|
been shown both versions and chosen. #}
|
|
<input type="hidden" name="revision" value="">
|
|
<label class="visually-hidden" for="canvas-mine">{{ t("Your version") }}</label>
|
|
<textarea class="canvas__editor" id="canvas-mine" name="text"
|
|
spellcheck="false" data-canvas-editor>{{ mine }}</textarea>
|
|
<div class="canvas__actions">
|
|
<button class="btn btn--danger btn--sm" type="submit">
|
|
{{ icon("check", "icon--sm") }} Overwrite with mine
|
|
</button>
|
|
<button class="btn btn--sm" type="button"
|
|
hx-post="/api/chats/{{ chat.id }}/canvas/tabs"
|
|
hx-vals='{"key": {{ conflict.key | tojson }}}'
|
|
hx-target="#canvas-inner" hx-swap="innerHTML">{{ t("Discard mine and reload") }}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|