Houmeres/SageTube
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity

Improve MSI build error handling and fix FFmpeg setup

Browse Source 
Replaces PowerShell try/catch with exit code checks for MSI build steps in Windows workflow for clearer error reporting. Removes the install_icon option from FFmpeg MSI setup to address potential build failures.
This commit is contained in:
Your Name
2025-08-27 14:22:54 +03:00
parent c91768aec4
commit 498e6ae655
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/build-windows.yml
+8 -8
View File
@@ -88,11 +88,11 @@ jobs:
# Build MSI installer with error handling # Build MSI installer with error handling
Write-Host "Building standard MSI installer..." Write-Host "Building standard MSI installer..."
try { python build\windows\setup.py bdist_msi
python build\windows\setup.py bdist_msi if ($LASTEXITCODE -eq 0) {
Write-Host "Standard MSI build completed successfully" Write-Host "Standard MSI build completed successfully"
} catch { } else {
Write-Host "Error building standard MSI: $($_.Exception.Message)" Write-Host "Error building standard MSI - exit code: $LASTEXITCODE"
# Continue anyway to try ZIP creation # Continue anyway to try ZIP creation
} }
@@ -171,11 +171,11 @@ jobs:
# Build MSI installer with FFmpeg and error handling # Build MSI installer with FFmpeg and error handling
Write-Host "Building FFmpeg MSI installer..." Write-Host "Building FFmpeg MSI installer..."
try { python build\windows\setup-ffmpeg.py bdist_msi
python build\windows\setup-ffmpeg.py bdist_msi if ($LASTEXITCODE -eq 0) {
Write-Host "FFmpeg MSI build completed successfully" Write-Host "FFmpeg MSI build completed successfully"
} catch { } else {
Write-Host "Error building FFmpeg MSI: $($_.Exception.Message)" Write-Host "Error building FFmpeg MSI - exit code: $LASTEXITCODE"
# Continue anyway to try ZIP creation # Continue anyway to try ZIP creation
} }
build/windows/setup-ffmpeg.py
+2 -1
View File
@@ -91,7 +91,8 @@ bdist_msi_options = {
"upgrade_code": "{87654321-4321-8765-CBA9-987654321CBA}", # Different GUID for FFmpeg version "upgrade_code": "{87654321-4321-8765-CBA9-987654321CBA}", # Different GUID for FFmpeg version
"add_to_path": False, "add_to_path": False,
"initial_target_dir": r"[ProgramFilesFolder]\YTSage", "initial_target_dir": r"[ProgramFilesFolder]\YTSage",
"install_icon": "assets/branding/icons/YTSage.ico", # Remove problematic install_icon that might be causing MSI build to fail
# "install_icon": "assets/branding/icons/YTSage.ico",
"summary_data": { "summary_data": {
"author": "oop7", "author": "oop7",
"comments": "YouTube Video Downloader with FFmpeg - Complete video processing solution", "comments": "YouTube Video Downloader with FFmpeg - Complete video processing solution",