Houmeres/SageTube
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity

Remove redundant file existence check in downloader

Browse Source 
Eliminated the check_file_exists method and related logic, as file existence is now handled by yt-dlp itself. This simplifies the DownloadThread class and avoids unnecessary pre-download checks.
This commit is contained in:
oop7
2025-11-04 22:06:30 +02:00
parent f88cf66a23
commit b3206d8890
1 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/ytsage_downloader.py
-18
View File
@@ -88,8 +88,6 @@ class DownloadThread(QThread):
self.paused = False self.paused = False
self.cancelled = False self.cancelled = False
self.process = None self.process = None
self.last_output_time = time.time()
self.timeout_timer = None
self.current_filename = None # Initialize filename storage self.current_filename = None # Initialize filename storage
self.last_file_path = None # Initialize full file path storage self.last_file_path = None # Initialize full file path storage
self.subtitle_files = [] # Track subtitle files that are created self.subtitle_files = [] # Track subtitle files that are created
@@ -158,13 +156,6 @@ class DownloadThread(QThread):
except Exception as e: except Exception as e:
logger.exception(f"Error cleaning subtitle files: {e}") logger.exception(f"Error cleaning subtitle files: {e}")
def check_file_exists(self) -> bool | None:
"""Check if the file already exists before downloading"""
# This method is kept for backwards compatibility but always returns False
# to proceed with download. File existence is now handled by yt-dlp CLI itself.
logger.debug("Skipping file existence check (handled by yt-dlp)")
return False # Proceed with download attempt
def _build_yt_dlp_command(self) -> list: def _build_yt_dlp_command(self) -> list:
"""Build the yt-dlp command line with all options for direct execution.""" """Build the yt-dlp command line with all options for direct execution."""
# Use the new yt-dlp path function from ytsage_yt_dlp module # Use the new yt-dlp path function from ytsage_yt_dlp module
@@ -295,15 +286,6 @@ class DownloadThread(QThread):
try: try:
logger.debug("Starting download thread") logger.debug("Starting download thread")
# First check if file already exists using original method
existing_file = self.check_file_exists()
if existing_file:
logger.debug(f"File exists, emitting signal: {existing_file}")
self.file_exists_signal.emit(existing_file)
return
logger.debug("No existing file found, proceeding with download")
# Get initial list of subtitle files to compare later # Get initial list of subtitle files to compare later
self.initial_subtitle_files = set() self.initial_subtitle_files = set()
if self.merge_subs: if self.merge_subs: