From b8804210dc719a6fff02225d5891dd340e015e49 Mon Sep 17 00:00:00 2001 From: oop7 <110548351+oop7@users.noreply.github.com> Date: Sat, 29 Nov 2025 13:41:06 +0200 Subject: [PATCH] Remove ffplay.exe from Windows build workflow Updated the build-windows.yml workflow to exclude ffplay.exe from verification and distribution steps, as only ffmpeg.exe and ffprobe.exe are required by the application. --- .github/workflows/build-windows.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 35cf2ac..f2e1220 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -183,10 +183,9 @@ jobs: Write-Host "FFmpeg binaries found at: $ffmpegBinPath" echo "FFMPEG_PATH=$ffmpegBinPath" >> $env:GITHUB_ENV - # Verify files exist + # Verify files exist (only ffmpeg and ffprobe are needed) $ffmpegExe = Join-Path $ffmpegBinPath "ffmpeg.exe" $ffprobeExe = Join-Path $ffmpegBinPath "ffprobe.exe" - $ffplayExe = Join-Path $ffmpegBinPath "ffplay.exe" if (Test-Path $ffmpegExe) { Write-Host "[OK] ffmpeg.exe found" @@ -198,11 +197,6 @@ jobs: } else { Write-Host "[ERROR] ffprobe.exe missing" } - if (Test-Path $ffplayExe) { - Write-Host "[OK] ffplay.exe found" - } else { - Write-Host "[ERROR] ffplay.exe missing" - } } else { Write-Host "Error: Could not find FFmpeg directory after extraction" exit 1 @@ -232,13 +226,13 @@ jobs: } # Copy FFmpeg binaries into dist folder post-build (more reliable than CLI include) + # Note: ffplay.exe is excluded as it's not needed by the application if ($env:FFMPEG_PATH) { $destDir = "dist\YTSage-FFmpeg" $ffmpegExe = Join-Path $env:FFMPEG_PATH "ffmpeg.exe" $ffprobeExe = Join-Path $env:FFMPEG_PATH "ffprobe.exe" - $ffplayExe = Join-Path $env:FFMPEG_PATH "ffplay.exe" - foreach ($file in @($ffmpegExe, $ffprobeExe, $ffplayExe)) { + foreach ($file in @($ffmpegExe, $ffprobeExe)) { if (Test-Path $file) { $name = Split-Path $file -Leaf Copy-Item $file -Destination (Join-Path $destDir $name) -Force