v4.9.0 - Refactor (#41)

* fix imports
remove unused imports
use full import path
sort import (1. Standard Library, 2. Third-Party, 3. Local) in alphabetic.

* - remove: Method 3 from src.core.ytsage_downlader:cleanup_subtitle_file
  - it could delete the subtitle file of other movies if it present in same directory as it scane recursively.

- refactor: migrate from os.path to pathlib.Path for path handling
  - Replaced os.path methods with pathlib.Path to improve readability,
  - avoid repeatation.
  - cross-platform compatibility, and maintain cleaner code.

- improve: enhance code readability
  - Standardized string literals to use double quotes for consistency
  - Removed unnecessary spaces to maintain cleaner formatting
  - Applied code formatting for better readability and maintainability

* - add: ytsage_constants.py file for one place to store all constants.

- imporve: return type hint for function.

- remove: src/gui/ytsage_gui_dialogs.py file to avoid repetation
  - src/gui/dialogs is renamed to src/gui/ytsage_gui_dialogs for same naming convection. (future import will remains same)
  - use of src/gui/ytsage_gui_dialogs/__init__.py to import the dilogs modules.

- change: variable self.parent to self._parent so it does not overwrite the parent()
  - add type hint checking.

* - refactor: QMetaObject.invokeMethod to Signal
  - I encounter error with incokeMethod. Could not solve it.
  - So, Changed it to Signal to match app code language.

- implement: the ytsage_constants.py to code
  - remove: unnecessary logic
  - remove: repetitive code logic.

- update: yt-dlp logic for src\gui\ytsage_gui_dialogs\ytsage_dialogs_update:_update_binary
  - yt-dlp update logic will use `yt-dlp -U`

* refactor: remove unused imports and streamline code formatting across multiple files

* - **refactor: drop `pygame` in favor of built-in `PySide6` sound**

- Removed `pygame` dependency (too heavy just for notifications).
- Replaced with `QSoundEffect`, which is lightweight and built into `PySide6`.
- Dropped `pygame.mixer` + threading → Qt handles async playback.
- Implemented sound playback with `QUrl.fromLocalFile()` and `.play()`.
- Added `setVolume(0.9)` as a configurable example.
- Converted notification sound from `.mp3` to `.wav` (only format supported).

* **refactor(utils): simplify logger module**
  - Moved `logger` to `src.utils`
  - Removed unnecessary import checks (logger is always available)
  - Replaced `raise` statements with error logging to prevent crashes
  - Use `logger.exception()` in `except` blocks to capture traceback (logged as error)

**style: remove redundant str() in f-strings**
  - Dropped explicit `str()` calls inside f-strings
  - f-strings already call `str()` under the hood

**chore: add type hints for GUI mixins**
  - Added type hints for `FormatTableMixin` (`src.gui.ytsage_gui_format_table`)
  - Added type hints for `VideoInfoMixin` (`src.gui.ytsage_gui_video_info`)
  - Improves autocomplete and type safety in IDEs

* - **introduce the `ytsage_config_manager.py` module to manage app setting.**
  - Loads settings from a JSON config file (`APP_CONFIG_FILE`).
  - Creates the config file with default values if missing or corrupt.
  - Retrieves, sets, and deletes settings using simple dot-separated keys.
  - Provides safe error handling with logging instead of raising exceptions.
  - Persists updates back to disk automatically.

- **Usage**
```python
from src.utils.ytsage_config_manager import ConfigManager

download_path = ConfigManager.get("download_path")

ConfigManager.set("download_path", "D:/Downloads")

last_check = ConfigManager.get("cached_versions.ytdlp.last_check")

ConfigManager.delete("cached_versions.ffmpeg.path")
```

* **Refactore: pkg_resources with importlib.metadata.version**
  - UserWarning: pkg_resources is deprecated as an API.
  - See https://setuptools.pypa.io/en/latest/pkg_resources.html.
  - The pkg_resources package is slated for removal as early as 2025-11-30.

* **refactore: notification sound**
  - `QSoundEffect` is chnaged back to `pyglet` as per mainter `@oop7` choise.
  - simplify the logic.

* remove: import check, it should always work.

* **fix: runtime error**
  - yt_dlp moved from `--excludes` to `--packages` in `build-windows.yml`
  - In frozen build, logger will not log to consol. insted will log to file.
  - In frozen build, `app_dir` is next to `.exe` file.

* chang back to checking import for ytdlp

* Bump version to 4.8.1

Update version references from 4.8.0b to 4.8.1 in __init__.py, main app, and About dialog to reflect the new release.

* Update asset paths in build workflows

Changed asset inclusion and screenshot removal paths from 'assets' to 'lib/assets' in Linux, macOS, and Windows build workflows to reflect new directory structure and ensure screenshots are excluded from packaged builds.

* Bump version to 4.8.2

Update version references from 4.8.1 to 4.8.2 in source files and documentation to prepare for a new patch release.

* Fix asset include path in Windows build workflow

Corrects the syntax for including asset files in the build-windows.yml workflow by changing 'assets,lib/assets' to 'assets=lib/assets'. This ensures assets are properly mapped during the build process.

* Update release tag examples in CI/CD README

Changed the example git tag commands from v4.8.0 and v4.8.2 to v4.8.1 for consistency in the CI/CD documentation.

* Fix include-files mapping in Windows build workflow

Changed the cx_Freeze --include-files argument from '=' to ':' for source:destination mapping in build-windows.yml. This resolves an issue where '=' was treated as a literal path, ensuring assets are correctly copied to the destination directory.

* Remove redundant comments in build-windows workflow

Deleted comments explaining the colon usage for source:destination mapping in the cx_Freeze CLI, as the mapping is already clear from the context.

* Refactor Windows build to use cx_Freeze setup script

Replaces direct cx_Freeze CLI calls with dynamically generated setup scripts for both standard and FFmpeg builds. This improves maintainability and flexibility of build configuration in the GitHub Actions workflow.

* Bump version to 4.8.3

Updated version references from 4.8.2 to 4.8.3 in __init__.py, main app, and About dialog to reflect the new release.

* revert(build): move yt_dlp from --packages to --excludes in build-windows.yml

---------

Co-authored-by: Your Name <mohamed.mohamed112@ai.mnu.edu.eg>

src/core/ytsage_ffmpeg.py

@@ -7,7 +7,7 @@ from pathlib import Path
 
 import requests
 
-from src.core.ytsage_logging import logger
+from src.utils.ytsage_logger import logger
 from src.utils.ytsage_constants import (
     FFMPEG_7Z_DOWNLOAD_URL,
     FFMPEG_7Z_SHA256_URL,
@@ -46,7 +46,7 @@ def download_file(url, dest_path, progress_callback=None) -> bool:
                         progress_callback(f"⚡ Downloading FFmpeg components... {progress}%")
         return True
     except requests.RequestException as e:
-        logger.info(f"Download error: {str(e)}")
+        logger.info(f"Download error: {e}")
         return False
 
 
@@ -80,7 +80,7 @@ def verify_sha256(file_path, expected_hash_url) -> bool:
             logger.info(f"Actual:   {actual_hash}")
             return False
     except Exception as e:
-        logger.info(f"⚠️ SHA-256 verification error: {str(e)}")
+        logger.info(f"⚠️ SHA-256 verification error: {e}")
         return False
 
 
@@ -128,7 +128,7 @@ def get_ffmpeg_path() -> str | Path:
                 ffmpeg_path = result.stdout.strip()
                 return ffmpeg_path
     except Exception as e:
-        logger.error(f"Error finding ffmpeg in PATH: {e}")
+        logger.exception(f"Error finding ffmpeg in PATH: {e}")
 
     # If not found in PATH, check the installation directory
     ffmpeg_install_path = get_ffmpeg_install_path()
@@ -171,7 +171,7 @@ def check_ffmpeg_installed() -> bool:
             return True
         return False
     except Exception as e:
-        logger.info(f"FFmpeg check error: {str(e)}")
+        logger.info(f"FFmpeg check error: {e}")
         return False
 
 
@@ -219,7 +219,7 @@ def install_ffmpeg_windows() -> bool:
                             timeout=300,
                         )  # 5-minute timeout
                     except Exception as e:
-                        logger.error(f"7z extraction failed: {str(e)}, trying zip fallback...")
+                        logger.exception(f"7z extraction failed: {e}, trying zip fallback...")
                         use_7zip = False
                 else:
                     logger.error("SHA-256 verification failed for 7z file, trying zip fallback...")
@@ -236,7 +236,8 @@ def install_ffmpeg_windows() -> bool:
                 temp_file,
                 progress_callback=lambda msg: logger.debug(msg),
             ):
-                raise Exception("Failed to download FFmpeg (both 7z and zip methods failed)")
+                logger.exception("Failed to download FFmpeg (both 7z and zip methods failed)")
+                return False
 
             logger.info("Extracting FFmpeg components from zip archive...")
             try:
@@ -245,7 +246,8 @@ def install_ffmpeg_windows() -> bool:
                 with zipfile.ZipFile(temp_file, "r") as zip_ref:
                     zip_ref.extractall(extract_dir)
             except Exception as e:
-                raise Exception(f"Extraction failed: {str(e)}")
+                logger.exception(f"Extraction failed: {e}")
+                return False
 
         logger.info("Configuring system paths...")
         # Add to System Path
@@ -265,13 +267,14 @@ def install_ffmpeg_windows() -> bool:
 
         # Verify installation
         if not check_ffmpeg_installed():
-            raise Exception("FFmpeg installation verification failed")
+            logger.error("FFmpeg installation verification failed")
+            return False
 
         logger.info("FFmpeg installation completed successfully!")
         return True
 
     except Exception as e:
-        logger.error(f"Error installing FFmpeg: {str(e)}")
+        logger.exception(f"Error installing FFmpeg: {e}")
         return False
 
 
@@ -298,12 +301,13 @@ def install_ffmpeg_macos() -> bool:
 
         # Verify installation
         if not check_ffmpeg_installed():
-            raise Exception("FFmpeg installation verification failed")
+            logger.error("FFmpeg installation verification failed")
+            return False
 
         return True
 
     except Exception as e:
-        logger.error(f"Error installing FFmpeg: {str(e)}")
+        logger.exception(f"Error installing FFmpeg: {e}")
         return False
 
 
@@ -329,16 +333,18 @@ def install_ffmpeg_linux() -> bool:
             # Universal snap package
             subprocess.run(["sudo", "snap", "install", "ffmpeg"], check=True, timeout=300)
         else:
-            raise Exception("No supported package manager found")
+            logger.error("No supported package manager found")
+            return False
 
         # Verify installation
         if not check_ffmpeg_installed():
-            raise Exception("FFmpeg installation verification failed")
+            logger.error("FFmpeg installation verification failed")
+            return False
 
         return True
 
     except Exception as e:
-        logger.error(f"Error installing FFmpeg: {str(e)}")
+        logger.exception(f"Error installing FFmpeg: {e}")
         return False