v4.9.0 - Refactor (#41)

* fix imports
remove unused imports
use full import path
sort import (1. Standard Library, 2. Third-Party, 3. Local) in alphabetic.

* - remove: Method 3 from src.core.ytsage_downlader:cleanup_subtitle_file
  - it could delete the subtitle file of other movies if it present in same directory as it scane recursively.

- refactor: migrate from os.path to pathlib.Path for path handling
  - Replaced os.path methods with pathlib.Path to improve readability,
  - avoid repeatation.
  - cross-platform compatibility, and maintain cleaner code.

- improve: enhance code readability
  - Standardized string literals to use double quotes for consistency
  - Removed unnecessary spaces to maintain cleaner formatting
  - Applied code formatting for better readability and maintainability

* - add: ytsage_constants.py file for one place to store all constants.

- imporve: return type hint for function.

- remove: src/gui/ytsage_gui_dialogs.py file to avoid repetation
  - src/gui/dialogs is renamed to src/gui/ytsage_gui_dialogs for same naming convection. (future import will remains same)
  - use of src/gui/ytsage_gui_dialogs/__init__.py to import the dilogs modules.

- change: variable self.parent to self._parent so it does not overwrite the parent()
  - add type hint checking.

* - refactor: QMetaObject.invokeMethod to Signal
  - I encounter error with incokeMethod. Could not solve it.
  - So, Changed it to Signal to match app code language.

- implement: the ytsage_constants.py to code
  - remove: unnecessary logic
  - remove: repetitive code logic.

- update: yt-dlp logic for src\gui\ytsage_gui_dialogs\ytsage_dialogs_update:_update_binary
  - yt-dlp update logic will use `yt-dlp -U`

* refactor: remove unused imports and streamline code formatting across multiple files

* - **refactor: drop `pygame` in favor of built-in `PySide6` sound**

- Removed `pygame` dependency (too heavy just for notifications).
- Replaced with `QSoundEffect`, which is lightweight and built into `PySide6`.
- Dropped `pygame.mixer` + threading → Qt handles async playback.
- Implemented sound playback with `QUrl.fromLocalFile()` and `.play()`.
- Added `setVolume(0.9)` as a configurable example.
- Converted notification sound from `.mp3` to `.wav` (only format supported).

* **refactor(utils): simplify logger module**
  - Moved `logger` to `src.utils`
  - Removed unnecessary import checks (logger is always available)
  - Replaced `raise` statements with error logging to prevent crashes
  - Use `logger.exception()` in `except` blocks to capture traceback (logged as error)

**style: remove redundant str() in f-strings**
  - Dropped explicit `str()` calls inside f-strings
  - f-strings already call `str()` under the hood

**chore: add type hints for GUI mixins**
  - Added type hints for `FormatTableMixin` (`src.gui.ytsage_gui_format_table`)
  - Added type hints for `VideoInfoMixin` (`src.gui.ytsage_gui_video_info`)
  - Improves autocomplete and type safety in IDEs

* - **introduce the `ytsage_config_manager.py` module to manage app setting.**
  - Loads settings from a JSON config file (`APP_CONFIG_FILE`).
  - Creates the config file with default values if missing or corrupt.
  - Retrieves, sets, and deletes settings using simple dot-separated keys.
  - Provides safe error handling with logging instead of raising exceptions.
  - Persists updates back to disk automatically.

- **Usage**
```python
from src.utils.ytsage_config_manager import ConfigManager

download_path = ConfigManager.get("download_path")

ConfigManager.set("download_path", "D:/Downloads")

last_check = ConfigManager.get("cached_versions.ytdlp.last_check")

ConfigManager.delete("cached_versions.ffmpeg.path")
```

* **Refactore: pkg_resources with importlib.metadata.version**
  - UserWarning: pkg_resources is deprecated as an API.
  - See https://setuptools.pypa.io/en/latest/pkg_resources.html.
  - The pkg_resources package is slated for removal as early as 2025-11-30.

* **refactore: notification sound**
  - `QSoundEffect` is chnaged back to `pyglet` as per mainter `@oop7` choise.
  - simplify the logic.

* remove: import check, it should always work.

* **fix: runtime error**
  - yt_dlp moved from `--excludes` to `--packages` in `build-windows.yml`
  - In frozen build, logger will not log to consol. insted will log to file.
  - In frozen build, `app_dir` is next to `.exe` file.

* chang back to checking import for ytdlp

* Bump version to 4.8.1

Update version references from 4.8.0b to 4.8.1 in __init__.py, main app, and About dialog to reflect the new release.

* Update asset paths in build workflows

Changed asset inclusion and screenshot removal paths from 'assets' to 'lib/assets' in Linux, macOS, and Windows build workflows to reflect new directory structure and ensure screenshots are excluded from packaged builds.

* Bump version to 4.8.2

Update version references from 4.8.1 to 4.8.2 in source files and documentation to prepare for a new patch release.

* Fix asset include path in Windows build workflow

Corrects the syntax for including asset files in the build-windows.yml workflow by changing 'assets,lib/assets' to 'assets=lib/assets'. This ensures assets are properly mapped during the build process.

* Update release tag examples in CI/CD README

Changed the example git tag commands from v4.8.0 and v4.8.2 to v4.8.1 for consistency in the CI/CD documentation.

* Fix include-files mapping in Windows build workflow

Changed the cx_Freeze --include-files argument from '=' to ':' for source:destination mapping in build-windows.yml. This resolves an issue where '=' was treated as a literal path, ensuring assets are correctly copied to the destination directory.

* Remove redundant comments in build-windows workflow

Deleted comments explaining the colon usage for source:destination mapping in the cx_Freeze CLI, as the mapping is already clear from the context.

* Refactor Windows build to use cx_Freeze setup script

Replaces direct cx_Freeze CLI calls with dynamically generated setup scripts for both standard and FFmpeg builds. This improves maintainability and flexibility of build configuration in the GitHub Actions workflow.

* Bump version to 4.8.3

Updated version references from 4.8.2 to 4.8.3 in __init__.py, main app, and About dialog to reflect the new release.

* revert(build): move yt_dlp from --packages to --excludes in build-windows.yml

---------

Co-authored-by: Your Name <mohamed.mohamed112@ai.mnu.edu.eg>

src/gui/ytsage_gui_dialogs/ytsage_dialogs_update.py

@@ -7,6 +7,7 @@ import os
 import subprocess
 import sys
 import time
+from importlib.metadata import PackageNotFoundError
 from pathlib import Path
 
 import requests
@@ -14,24 +15,26 @@ from packaging import version
 from PySide6.QtCore import Qt, QThread, QTimer, Signal
 from PySide6.QtWidgets import QDialog, QHBoxLayout, QLabel, QProgressBar, QPushButton, QVBoxLayout
 
-from src.core.ytsage_logging import logger
 from src.core.ytsage_utils import get_ytdlp_version, load_config, save_config
 from src.core.ytsage_yt_dlp import get_yt_dlp_path
 from src.utils.ytsage_constants import OS_NAME, SUBPROCESS_CREATIONFLAGS, YTDLP_APP_BIN_PATH, YTDLP_DOWNLOAD_URL
+from src.utils.ytsage_logger import logger
 
 try:
-    from importlib.metadata import version as importlib_version
     from importlib.metadata import PackageNotFoundError as ImportlibPackageNotFoundError
-    
+    from importlib.metadata import version as importlib_version
+
     def get_version(package_name: str) -> str:
         return importlib_version(package_name)
-    
+
     PackageNotFoundError = ImportlibPackageNotFoundError
 except ImportError:
     # Fallback for older Python versions
     import pkg_resources
+
     def get_version(package_name: str) -> str:
         return pkg_resources.get_distribution(package_name).version
+
     PackageNotFoundError = pkg_resources.DistributionNotFound
 
 try:
@@ -71,7 +74,7 @@ class VersionCheckThread(QThread):
                     else:
                         error_message = "yt-dlp not available."
                         self.finished.emit(current_version, latest_version, error_message)
-                        return
+                    return
             except subprocess.TimeoutExpired:
                 # Try fallback if timeout
                 if YT_DLP_AVAILABLE:
@@ -162,11 +165,11 @@ class UpdateThread(QThread):
                 error_message = "❌ Failed to update yt-dlp. Please try again or check your internet connection."
 
         except requests.RequestException as e:
-            error_message = f"❌ Network error during update: {str(e)}"
+            error_message = f"❌ Network error during update: {e}"
             self.update_status.emit(error_message)
             success = False
         except Exception as e:
-            error_message = f"❌ Update failed: {str(e)}"
+            error_message = f"❌ Update failed: {e}"
             self.update_status.emit(error_message)
             success = False
 
@@ -207,7 +210,7 @@ class UpdateThread(QThread):
             return False
 
         except Exception as e:
-            logger.error(f"UpdateThread: Unexpected error during update: {e}", exc_info=True)
+            logger.exception(f"UpdateThread: Unexpected error during update: {e}")
             self.update_status.emit(f"❌ Unexpected error during update: {e}")
             return False
 
@@ -553,10 +556,7 @@ class AutoUpdateThread(QThread):
                 logger.warning(f"AutoUpdateThread: Network error during auto-update check: {e}")
                 self.update_finished.emit(False, f"Network error: {e}")
             except Exception as e:
-                logger.error(
-                    f"AutoUpdateThread: Error during auto-update check: {e}",
-                    exc_info=True,
-                )
+                logger.exception(f"AutoUpdateThread: Error during auto-update check: {e}", exc_info=True)
                 self.update_finished.emit(False, f"Update check error: {e}")
 
         except Exception as e:
@@ -595,7 +595,7 @@ class AutoUpdateThread(QThread):
                 return self._update_via_pip()
 
         except Exception as e:
-            logger.error(f"AutoUpdateThread: Error in _perform_update: {e}", exc_info=True)
+            logger.exception(f"AutoUpdateThread: Error in _perform_update: {e}")
             return False
 
     def _update_binary(self, yt_dlp_path: Path) -> bool:
@@ -629,7 +629,7 @@ class AutoUpdateThread(QThread):
             return False
 
         except Exception as e:
-            logger.error(f"AutoUpdateThread: Unexpected error during update: {e}", exc_info=True)
+            logger.exception(f"AutoUpdateThread: Unexpected error during update: {e}")
             return False
 
     def _update_via_pip(self) -> bool:
@@ -684,5 +684,5 @@ class AutoUpdateThread(QThread):
                 return True
 
         except Exception as e:
-            logger.error(f"AutoUpdateThread: Pip update failed: {e}", exc_info=True)
+            logger.exception(f"AutoUpdateThread: Pip update failed: {e}")
             return False