v4.9.0 - Refactor (#41)

* fix imports
remove unused imports
use full import path
sort import (1. Standard Library, 2. Third-Party, 3. Local) in alphabetic.

* - remove: Method 3 from src.core.ytsage_downlader:cleanup_subtitle_file
  - it could delete the subtitle file of other movies if it present in same directory as it scane recursively.

- refactor: migrate from os.path to pathlib.Path for path handling
  - Replaced os.path methods with pathlib.Path to improve readability,
  - avoid repeatation.
  - cross-platform compatibility, and maintain cleaner code.

- improve: enhance code readability
  - Standardized string literals to use double quotes for consistency
  - Removed unnecessary spaces to maintain cleaner formatting
  - Applied code formatting for better readability and maintainability

* - add: ytsage_constants.py file for one place to store all constants.

- imporve: return type hint for function.

- remove: src/gui/ytsage_gui_dialogs.py file to avoid repetation
  - src/gui/dialogs is renamed to src/gui/ytsage_gui_dialogs for same naming convection. (future import will remains same)
  - use of src/gui/ytsage_gui_dialogs/__init__.py to import the dilogs modules.

- change: variable self.parent to self._parent so it does not overwrite the parent()
  - add type hint checking.

* - refactor: QMetaObject.invokeMethod to Signal
  - I encounter error with incokeMethod. Could not solve it.
  - So, Changed it to Signal to match app code language.

- implement: the ytsage_constants.py to code
  - remove: unnecessary logic
  - remove: repetitive code logic.

- update: yt-dlp logic for src\gui\ytsage_gui_dialogs\ytsage_dialogs_update:_update_binary
  - yt-dlp update logic will use `yt-dlp -U`

* refactor: remove unused imports and streamline code formatting across multiple files

* - **refactor: drop `pygame` in favor of built-in `PySide6` sound**

- Removed `pygame` dependency (too heavy just for notifications).
- Replaced with `QSoundEffect`, which is lightweight and built into `PySide6`.
- Dropped `pygame.mixer` + threading → Qt handles async playback.
- Implemented sound playback with `QUrl.fromLocalFile()` and `.play()`.
- Added `setVolume(0.9)` as a configurable example.
- Converted notification sound from `.mp3` to `.wav` (only format supported).

* **refactor(utils): simplify logger module**
  - Moved `logger` to `src.utils`
  - Removed unnecessary import checks (logger is always available)
  - Replaced `raise` statements with error logging to prevent crashes
  - Use `logger.exception()` in `except` blocks to capture traceback (logged as error)

**style: remove redundant str() in f-strings**
  - Dropped explicit `str()` calls inside f-strings
  - f-strings already call `str()` under the hood

**chore: add type hints for GUI mixins**
  - Added type hints for `FormatTableMixin` (`src.gui.ytsage_gui_format_table`)
  - Added type hints for `VideoInfoMixin` (`src.gui.ytsage_gui_video_info`)
  - Improves autocomplete and type safety in IDEs

* - **introduce the `ytsage_config_manager.py` module to manage app setting.**
  - Loads settings from a JSON config file (`APP_CONFIG_FILE`).
  - Creates the config file with default values if missing or corrupt.
  - Retrieves, sets, and deletes settings using simple dot-separated keys.
  - Provides safe error handling with logging instead of raising exceptions.
  - Persists updates back to disk automatically.

- **Usage**
```python
from src.utils.ytsage_config_manager import ConfigManager

download_path = ConfigManager.get("download_path")

ConfigManager.set("download_path", "D:/Downloads")

last_check = ConfigManager.get("cached_versions.ytdlp.last_check")

ConfigManager.delete("cached_versions.ffmpeg.path")
```

* **Refactore: pkg_resources with importlib.metadata.version**
  - UserWarning: pkg_resources is deprecated as an API.
  - See https://setuptools.pypa.io/en/latest/pkg_resources.html.
  - The pkg_resources package is slated for removal as early as 2025-11-30.

* **refactore: notification sound**
  - `QSoundEffect` is chnaged back to `pyglet` as per mainter `@oop7` choise.
  - simplify the logic.

* remove: import check, it should always work.

* **fix: runtime error**
  - yt_dlp moved from `--excludes` to `--packages` in `build-windows.yml`
  - In frozen build, logger will not log to consol. insted will log to file.
  - In frozen build, `app_dir` is next to `.exe` file.

* chang back to checking import for ytdlp

* Bump version to 4.8.1

Update version references from 4.8.0b to 4.8.1 in __init__.py, main app, and About dialog to reflect the new release.

* Update asset paths in build workflows

Changed asset inclusion and screenshot removal paths from 'assets' to 'lib/assets' in Linux, macOS, and Windows build workflows to reflect new directory structure and ensure screenshots are excluded from packaged builds.

* Bump version to 4.8.2

Update version references from 4.8.1 to 4.8.2 in source files and documentation to prepare for a new patch release.

* Fix asset include path in Windows build workflow

Corrects the syntax for including asset files in the build-windows.yml workflow by changing 'assets,lib/assets' to 'assets=lib/assets'. This ensures assets are properly mapped during the build process.

* Update release tag examples in CI/CD README

Changed the example git tag commands from v4.8.0 and v4.8.2 to v4.8.1 for consistency in the CI/CD documentation.

* Fix include-files mapping in Windows build workflow

Changed the cx_Freeze --include-files argument from '=' to ':' for source:destination mapping in build-windows.yml. This resolves an issue where '=' was treated as a literal path, ensuring assets are correctly copied to the destination directory.

* Remove redundant comments in build-windows workflow

Deleted comments explaining the colon usage for source:destination mapping in the cx_Freeze CLI, as the mapping is already clear from the context.

* Refactor Windows build to use cx_Freeze setup script

Replaces direct cx_Freeze CLI calls with dynamically generated setup scripts for both standard and FFmpeg builds. This improves maintainability and flexibility of build configuration in the GitHub Actions workflow.

* Bump version to 4.8.3

Updated version references from 4.8.2 to 4.8.3 in __init__.py, main app, and About dialog to reflect the new release.

* revert(build): move yt_dlp from --packages to --excludes in build-windows.yml

---------

Co-authored-by: Your Name <mohamed.mohamed112@ai.mnu.edu.eg>

src/gui/ytsage_gui_format_table.py

@@ -1,7 +1,12 @@
+from typing import TYPE_CHECKING, cast
+
 from PySide6.QtCore import QObject, Qt, Signal
 from PySide6.QtGui import QColor
 from PySide6.QtWidgets import QCheckBox, QHBoxLayout, QHeaderView, QSizePolicy, QTableWidget, QTableWidgetItem, QWidget
 
+if TYPE_CHECKING:
+    from src.gui.ytsage_gui_main import YTSageApp
+
 
 class FormatSignals(QObject):
     format_update = Signal(list)
@@ -9,8 +14,9 @@ class FormatSignals(QObject):
 
 class FormatTableMixin:
     def setup_format_table(self) -> QTableWidget:
-        self.format_signals = FormatSignals()
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
 
+        self.format_signals = FormatSignals()
         # Format table with improved styling
         self.format_table = QTableWidget()
         self.format_table.setColumnCount(8)
@@ -124,6 +130,8 @@ class FormatTableMixin:
         return self.format_table
 
     def filter_formats(self) -> None:
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+
         if not hasattr(self, "all_formats"):
             return
 
@@ -165,6 +173,8 @@ class FormatTableMixin:
         self.format_signals.format_update.emit(filtered_formats)
 
     def _update_format_table(self, formats) -> None:
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+
         self.format_table.setRowCount(0)
         self.format_checkboxes.clear()
 
@@ -331,22 +341,30 @@ class FormatTableMixin:
                 self.format_table.setItem(row, 7, notes_item)
 
     def handle_checkbox_click(self, clicked_checkbox) -> None:
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+
         for checkbox in self.format_checkboxes:
             if checkbox != clicked_checkbox:
                 checkbox.setChecked(False)
 
     def get_selected_format(self):
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+
         for checkbox in self.format_checkboxes:
             if checkbox.isChecked():
                 return checkbox.format_id
         return None
 
     def update_format_table(self, formats) -> None:
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+
         self.all_formats = formats
         self.format_signals.format_update.emit(formats)
 
     def get_quality_label(self, format_info) -> str:
         """Determine quality label based on format information"""
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+        
         if format_info.get("vcodec") == "none":
             # Audio quality
             abr = format_info.get("abr", 0)
@@ -383,17 +401,12 @@ class FormatTableMixin:
 
     def _get_format_notes(self, format_info) -> str:
         """Generate helpful format notes based on format info."""
+        self = cast("YTSageApp", self)  # for autocompletion and type inference.
+        
         notes = []
 
         # Add storage indicator with more granular categories
         file_size = format_info.get("filesize") or format_info.get("filesize_approx", 0)
-        resolution = format_info.get("resolution", "")
-        height = 0
-        if resolution:
-            try:
-                height = int(resolution.split("x")[1])
-            except:
-                pass
 
         # Better file size categories
         if file_size > 50 * 1024 * 1024:  # Over 50MB