3aca43b372
There was no icon system at all. Transport buttons called QStyle.standardIcon(SP_MediaPlay), which returns the platform theme's dark monochrome glyph -- painted onto the app's saturated red buttons at a fixed 36px with no text, that is the black square. Everything else called an icon was an emoji baked into en.json, which is tofu wherever the emoji font is missing. Qt stylesheets cannot recolour a QIcon, so the colour is an argument to the new helper; that is the whole fix. The SVGs are drawn here rather than vendored, which keeps a third-party licence out of the tree, and they live in the module rather than as asset files, which keeps them out of package-data and safe in a frozen build. Tooltips were the other half: three widgets in the entire application had one and nothing set an accessible name. Filling that in at the call sites would have meant editing well over a hundred of them, most in upstream-owned files. Instead one application-level event filter handles QEvent.Polish, which Qt sends to every widget once before it is shown -- so it also reaches dialogs built by upstream code, and survives the next merge. It maps placeholder emoji to icons, fills empty tooltips from the button text, and logs icon-only buttons that still have none so the gaps are findable. StyleSheet.MAIN styles the window, inputs, buttons and tables and nothing else, so the main tab bar, combos, sliders, lists, menus, splitters, tooltips and the horizontal scrollbar fell through to the platform style. EXTRA_QSS covers them, in a fork-owned module appended at the one application site. SmoothTabWidget names its frame "tabContent" with the comment "We draw border on content instead" -- that rule existed only inside two dialogs, and now exists for the main window too. Two corrections to rules that were already there: the pressed style changed the padding, shifting every label two pixels and clipping fixed-width icon buttons, and checkboxes were fully rounded, which reads as a radio button rather than an on/off toggle. Verified by screenshot on the real display: tab bar, buttons, combo carets and checkboxes all render as intended, and all 35 icons rasterise non-empty. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
7.1 KiB
7.1 KiB
Changelog
Kept as the work happens, not assembled at release time. Format is Keep a Changelog; versions follow SemVer.
The vX.Y.Z tags already on this repository are upstream YTSage's, inherited
with its history. SageTube's own versions start below and are the ones this file
records.
Unreleased
Added
- Real icons. The app had no icon system: transport buttons used the
platform style's dark monochrome glyphs painted on saturated red, and
everything else called an icon was an emoji baked into the English strings.
A drawn SVG set is now rendered through QtSvg and recoloured at load — Qt
stylesheets cannot recolour a
QIcon, which is exactly why the old ones were unreadable. Buttons across the Downloads tab gained icons too. - Tooltips and accessible names on every button. Three widgets in the whole application had a tooltip. An application-level polish filter now fills them in as each button is first shown, and swaps placeholder emoji for icons — which covers dialogs owned by upstream without editing them.
Fixed
- The rest of the interface is themed.
StyleSheet.MAINstyled the window, inputs, buttons and tables and nothing else, so the main tab bar, combo boxes, sliders, lists, menus, splitters, tooltips and the horizontal scrollbar were drawn by the platform — the tab bar with white text forced onto system-coloured tabs, tooltips in the system's light style on a black app. All of them now match.QFrame#tabContentfinally has the rule the tab widget's own comment promised. - Checkboxes were round, which reads as a radio button — "one of these" rather than "on or off". They are square with a tick.
- Clicking any button shifted its label two pixels down and right, and clipped the artwork on fixed-width icon buttons: the pressed style changed the padding. The background change alone reads as pressed.
- The window icon shipped only at 48px and was upscaled everywhere; the 256px master now ships beside it. Its fallback was the platform's download arrow standing in for the application's identity.
- The player no longer crashes the app. Qt destroys and recreates a
widget's OpenGL context whenever it moves to another top-level window, and
calls
initializeGL()again. libmpv allows one render context per handle, so the second creation failed — and the failure path dropped the last reference to the first context while libmpv still held a function pointer into it. Python then collected the callback trampoline under libmpv's feet and the next frame notification jumped into freed memory.initializeGL()now tears down first so recreation is clean, teardown clears the callback and frees with the GL context current, and it is wired toQOpenGLContext.aboutToBeDestroyedso it runs before the context goes away rather than never. Verified over ten forced context destroy/recreate cycles. - Fullscreen no longer reparents the video. It took the player out of its layout and into a new top-level window, destroying the OpenGL context twice per toggle — the most direct route to the crash above — and on the way back re-added the panel at the end of the splitter, so the video reappeared beside the queue with the pane sizes lost. The main window now goes fullscreen and the chrome around the video is hidden instead. Nothing is reparented.
- Switching tabs no longer risks the player. The cross-fade grabbed a screenshot of the outgoing page; on an OpenGL surface that forces a framebuffer readback and returns black, so the "fade" was a black slab and the readback endangered the context. Pages containing the video now switch without the fade.
- Dialogs dimmed instead of blurred while the player exists, for the same reason — every dialog in the app screenshotted the whole window.
- The saved volume never reached mpv: the slider set its restored value before its change signal was connected, so playback always started at 100.
Changed
- mpv is given an explicit
hwdeclist per platform (player.hwdec, defaultauto), each ending in software decoding, so a machine with broken GPU interop plays rather than showing a black frame. This does not silenceCannot load libcuda.so.1— that comes from the driver stack below mpv and appears withhwdec=notoo. - The update check now looks at SageTube's own releases. It queried PyPI's
ytsagepackage for the version andoop7/YTSagefor the changelog, then linked to upstream's downloads — a different program's release stream. It now readsgit.houmeres.sk/Houmeres/SageTubereleases, anonymously, and the "Download update" button opens this repository's release page. - The beta channel follows SageTube pre-releases. Upstream's inherited
btags (v5.3.0band earlier) read as pre-releases, so a stable instance cannot be offered one. - The check now runs at most once a day rather than on every start.
- The About dialog and the update settings say SageTube rather than YTSage. The "Based on YTSage by oop7" attribution link stays — it is the MIT credit.
Added
- Skip this version in the update dialog. The skipped version is never offered again; later ones still are.
Fixed
- The app no longer offers upstream YTSage's releases as its own updates.
__version__andpyproject.tomlhad been left at the scaffolded0.1.0while the released tag wasv5.4.0, so every comparison against upstream's published version reported an update. Both now read5.4.0, the single source of truth for the window title, the About dialog and the update check. ConfigManagermerged a stored config over the defaults shallowly, so a file written by an older build replaced whole nested objects: a stored"player"or"feed"containing only some keys silently discarded every default added since. The merge is now recursive. Keys present only in the stored file are preserved, so downgrading cannot destroy settings.- Opening Custom Options and clicking OK re-enabled the update checker, because
the settings tab read a missing
check_app_updatesas enabled and then persisted that reading unconditionally.
Changed
- Configs now carry
config_version. A file written before 5.4.0 — including one inherited from an upstream YTSage install — has its storedcheck_app_updatescleared once, so SageTube's own default applies rather than a setting that pointed at another project's releases.
5.4.0 — 2026-08-08
Changed
- The documentation left the repository:
docs/BUILDING.md,docs/UPSTREAM.mdanddocs/UPSTREAM_README.mdare now the wiki. - The history was deliberately not rewritten. Every other repository in this
org had its documentation removed from every commit on 2026-08-08. SageTube is
a fork that still merges from
oop7/YTSage, and a rewrite changes every commit id — which would end that. The files leave in an ordinary commit instead. .github/andreadme-translations/are upstream's and were left alone, so the next merge does not conflict over them.