Homer
fd744a1a85
The cookie login was not missing, it was buried: Downloads tab -> Custom Options -> the "Login with Cookies" tab, where Downloads is one tab of five. The three features that depend on it -- the Feed's account mode, Search and Browse -- are other tabs, with no route to it. show_cookie_login_dialog(), which opens that dialog on the right tab, had no caller anywhere in the codebase; it does now. An account button sits in the corner of the tab bar, visible from every tab, saying whether cookies are in use and where they came from. The Feed offers the same thing next to its account mode rather than greying the option out and leaving it at that, and the disabled entry now says why it is disabled. Applying cookies used to require a restart before playback saw them: _build_ytdl_raw_options was read once, when the player widget was built. A cookiesChanged signal now reaches the account button, the Feed and the live mpv handle, and the player reloads at its current position -- ytdl_hook consults the option when it resolves a URL, so anything already playing keeps the streams it resolved with. YtdlpClient needed no change: it re-reads config per call. Two bugs in the same function: the options are joined with commas and were never escaped, so a cookie path or a proxy URL containing one silently ended the option and started a bogus one; and geo_proxy_url was honoured by the downloader but never passed to the player, so a geo-restricted video would download and then refuse to play. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
27 lines
1.2 KiB
Python
27 lines
1.2 KiB
Python
"""
|
|
AppRouter - cross-tab navigation signals
|
|
========================================
|
|
|
|
A tiny QObject signal hub connecting the watch-first pages (search, feed,
|
|
browse) with the player and the downloader tab. Pages emit; the main window
|
|
routes. Entry dicts are yt-dlp flat entries or the subset
|
|
{id, url, title, channel, channel_url, duration, thumbnail}.
|
|
"""
|
|
|
|
from PySide6.QtCore import QObject, Signal
|
|
|
|
|
|
class AppRouter(QObject):
|
|
playVideo = Signal(dict) # play immediately in the Watch tab
|
|
queueVideo = Signal(dict) # append to the play queue
|
|
downloadVideo = Signal(str) # open Downloads tab with URL prefilled + analyzed
|
|
openChannel = Signal(str) # open a channel URL in the Browse tab
|
|
openPlaylist = Signal(str) # open a playlist URL in the Browse tab
|
|
# Cookie settings were applied. YtdlpClient re-reads config per call so it
|
|
# needs no telling, but the account button, the Feed's mode availability
|
|
# and the live mpv handle all do -- otherwise signing in only takes effect
|
|
# after a restart.
|
|
cookiesChanged = Signal()
|
|
# Somewhere in the UI asked for the cookie login dialog.
|
|
cookieSetupRequested = Signal()
|